Ignore shellcheck SC2012 use find instead of ls 19/62819/3
authorThanh Ha <zxiiro@gmail.com>
Thu, 16 Jan 2020 00:18:18 +0000 (19:18 -0500)
committerAnil Belur <abelur@linuxfoundation.org>
Thu, 16 Jan 2020 02:56:57 +0000 (02:56 +0000)
It's reasonable to ignore this here as we're just piping ls to wc
to get a file count. The list of filenames is not being parsed in
anyway in this case.

SC2012: Use find instead of ls to better handle non-alphanumeric
        filenames.

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I0687b24816c2b4920893162297cd318f813d7109

shell/release-job.sh

index 5527688..ccaa782 100644 (file)
@@ -384,6 +384,7 @@ pypi_release_file(){
         echo "WARN: failed to download source distribution"
     fi
     echo "INFO: Checking files in $tgtdir"
+    # shellcheck disable=SC2012
     filecount=$(ls $tgtdir | wc -l)
     if [[ $filecount = 0 ]] ; then
         echo "ERROR: no files downloaded"