Fix: Add missing Python module dependency "munch" causing cleanup job failures

Issue: RELENG-5176
Change-Id: I758b6d86f9ae912f368c4380cafd8d4a0eabad4f
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>

Merge "Chore: Update GitHub actions for setup-python and artefact upload/download"

Chore: Update GitHub actions for setup-python and artefact upload/download

Issue: RELENG-5176
Change-Id: Ib9703988106f6d4223e9c6d7035a8cf39c904f09
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>

Merge "Chore: Update urllib3 pin to <2.1.0"

Chore: Update urllib3 pin to <2.1.0

Issue: RELENG-5176
Change-Id: Ibda2f27e79d9219489aa789c4e6bb39d5b6c502f
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>

Fix: Correct syntax for RTD extra requirements

Issue: RELENG-5171
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I877f83ea4f84f8207ee0f03c0d2ff3d71b20b791

Fix: Fix requirements install for RTD

Issue: RELENG-5171
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: Id9ee39d08b7aeeb86df488d2f8866167b278e654

Chore: Add missing release note for 0.37.9 tag

Change-Id: I46616cade08cd45f6c9e79efb3eb9a555b1bfa9c
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>

Chore: Update openstacksdk from <1.5.0 to >=2.1.0

Also, updated linting tool versions with pre-commit autoupdate.
Addressed minor type checking issue flagged by flake8.
Minor file formatting changes implemented via linting.

Issue: IT-26453
Change-Id: If9f941326c3f105d71fd0014d900653633d886ea
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>

CI: Remove release email

The lf-releng@lists.linuxfoundation.org mailing list is going away.
GitHub releases are already being generated (though the release notes
generation doesn't seem to be working 100% correctly) but this needs to
happen or we start getting failures soon.

Issue: RELENG-4931
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: Ib67a2f042a6c17837c366a0a82a300de8994d44e

Refactor: Update to using configparser

Since we've effectively dropped Python2 support there is no reason to
keep using six for backwards compatibility. This is the first of many
small changes to remove six from use.

This one is first as newer mypy seems to be having issues with the
configparser transition!

Issue: RELENG-5063
Change-Id: If9cd83933d0cd6e0b7ac69afaa1bb94a9dab8202
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Fix: Correct path for Jenkins settings files

The correct path should be "<repo>-settings", but was previously set
to just "<repo>". This is causing problems in our JCASC and other
automation.

Issue: RELENG-4490
Change-Id: I7f526d82d550acc3021548ee642a0d3706783d9f
Signed-off-by: Eric Ball <eball@linuxfoundation.org>

Fix: Move the git fetch depth

It is not possible to specify a depth larger than 1 with the tag
checkout that is performed. Move the depth increase to where it's
actually needed.

Issue: RELENG-4973
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I394c2359f8d8e8fec83bf5b39a9282222a9c2ad5

CI: Generate GitHub releases

* Increase the checkout depth from 1 to 30 to handle reno needing to be
  able to find all relevant tags (current and current -1) and also pull
  the tags
* Generate a reno report for the given tag and then modify the report to
  strip out all the extra garbage that is added by the report process to
  get it into a valid markdown file and not RST file
* Use `gh` cli tool to generate the release notes using the
  auto-changelog generation plus the reno release notes

Issue: RELENG-4973
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: Ic54ac4a5b138aabe2adcc3a9612f018ed34b4983

Revert "Refactor: Annotate lftools.deploy"

This reverts commit 0006fe3df413dcca4d03d26d9c33fdadb3498a26.

Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I7d57bc95825769c374333877b27eda628bfd9d6f

Fix: Tolerate transient connection errors

Nexus release process is absolutely critical and it seems just cannot
get our infra to work reliably. Work this around by ignoring
ConnectionErrors unless they pile up.

Issue: IT-25604
Change-Id: I3c035c280dd5ea973c188b78baec76e24aa1ec16
Signed-off-by: Robert Varga <nite@hq.sk>

Merge "Refactor: Annotate lftools.deploy"

Merge changes from topic "modernize_lftools"

* changes:
  Refactor: Add annotations to lftools.config
  Refactor: Add annotations to lftools.helpers
  Refactor: Add annotations to schema validator

Merge "Refactor: Add annotations to lftools.cli.version"

Merge "CI: Bring testing of lftools.cli.version to 100%"

Merge "Refactor: Add annotations on lftools.api.*"

Refactor: Add annotations to lftools.cli.version

Issue: RELENG-4933
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: If44a5dac471ef07c609bc8f26d70dbb34cc07def

CI: Bring testing of lftools.cli.version to 100%

Finish off the testing for lftools.cli.version

Issue: RELENG-4944
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: Id5ea7118f25e066c173b5a56f705d638f40689af

Chore: Add coverage reporting

Issue: RELENG-4938
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: Ic5589cd05033ee2f6758f10a84cb235317cc55df

Refactor: Add annotations on lftools.api.*

Issue: RELENG-4933
Change-Id: I2dde8fa02f2efac810a1ec874989ec1e94dfdeee
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Refactor: Annotate lftools.deploy

* Add annotations
* Refactor sections to deal with th needed changes for type enforcement
* Small rewrite of hard to follow logic that was exposed with type
  enforcement
* Cleanup most formatted strings

Issue: RELENG-4933
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: Idd435d831efc27954ca6e8c137b98ba8d728287d

Refactor: Add annotations to lftools.config

* Update lftools.oauth2_helper for new type hints out of config

Issue: RELENG-4933
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I7659432c722b1074c41f801170bac1b5b2c6b5d6

Refactor: Add annotations to lftools.helpers

Issue: RELENG-4933
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I28a94f82c6fdb04380cb2bc731ebc13811157ceb

Refactor: Add annotations to schema validator

Issue: RELENG-4933
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I1b13c1ad1ad825cf29718dd15c0cc56c8a4a55cc

Refactor: Add annoations to lftools.oauth2_helper

Issue: RELENG-4933
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I5d80203fa91196de29e77c55721150668545aeee

Refactor: Add annotations to lftools.license

Issue: RELENG-4933
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: Id3c7e98378b4a5251f266ed78a21e4311dea5aa5

Refactor: Add annotations to lftools.jenkins

Issue: RELENG-4933
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I94db9930f39c4421b20dc74d678c685a5b1ce0c5

Refactor: Add annotations to base lftools

Issue: RELENG-4933
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I9d793ebe4db3ca47dafee56c9016789f8bcd3f1f

Chore: Remove defunct requirements files

The requirements files being removed was missed in the previous change
to convert to using pyproject.toml

Issue: RELENG-4932
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I3e887e754413899d63f5b320904b275dcf3a94bc

Merge "Refactor: Migrate to pyproject.toml"

Refactor: Migrate to pyproject.toml

* Convert build configuration to a pure pyproject.toml project.
* Clamps reno notes generation to greater than v0.36.0

Issue: RELENG-4932
Change-Id: I10ebe156bb7712569fb06bd0c4b203074c3aed2b
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Chore: Bump base python to 3.8

Finalize the move to python 3.8 as our base python

Issue: RELENG-4891
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I4d3cea74a171baa6bdb540f8d4a29ac8d5cb4e02

Chore: Remove Python 3.5 - 3.7

Remove Python 3.5 - 3.7 from the defined compatible versions of lftools

Issue: RELENG-4891
Change-Id: Ia51f0dcce25b1c0394d690156d693df3f4f0e7b5
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

CI: Remove Python 3.7 from tox validation

Issue: RELENG-4891
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I4d8bd39c553f6804beada41f7fcbfaec756af75f

CI: Remove python 3.7 validation from GHA

Issue: RELENG-4891
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I0224c6a43c677aa2fba5d7450c5cd50500f11bd5

CI: Update python validation

* Drop python 3.6
* Set min version to 3.8
* Add python 3.9

Issue: RELENG-4891
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I6c5dfa4a7730783cdb1e2181e33503241f90109f
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Fix: Update github_cli call from deprecated method

The "set_repo_permission" method has been replaced by
"update_team_repository", which has the same signature, but
uses "pull" and "push" rather than "read" and "write" as the
permission strings.

Issue: RELENG-4481
Change-Id: I5167b07f85cbc063e4a4affabbd5ccf60a7dfa42
Signed-off-by: Eric Ball <eball@linuxfoundation.org>

Chore: Change "print" to "log" in github_cli

print statements should not be used for logging. These have been
replaced with log.info and log.error, where appropriate.

Change-Id: I919e5972dd887a0ed647b00250cbbe7a020f7d7e
Signed-off-by: Eric Ball <eball@linuxfoundation.org>

CI: Add RTD configuration file

RTD will soon be requiring a configuration file for builds.
Additionally, they will soon stop honoring the unshallow feature flag
that they have on the repository and to get an unshallow checkout we
must do so via the config file

Issue: RELENG-4815
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I41ae572570dcfb1b82a8457a5f008cb736ca3c0b

Chore: add new lines required by pre-commit

Signed-off-by: Kevin Sandi <ksandi@contractor.linuxfoundation.org>
Change-Id: I659776622fefceb233f3a444ec38f5174a5d5054

Fix: pin urllib3<2.0.0

The latest version of module breaks compatibility with
python-jenkins.

Issue: RELENG-4715
Change-Id: If0d942696820b8c867b56735ca3036aa3aa3b37c
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix: Correct version label for GHA call

Issue: RELENG-4563
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: Ia041c727d4787368a0eb26302a89110c047dbb9c

Fix: Correct bad actions call

Issue: RELENG-4563
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I5e960e68368a3471d73776b330d4bb12f489d043

Merge "Fix: Correct bad vars definition"

Fix: Correct missing steps designator

Issue: RELENG-4563
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I7412fafa1d91d464e367209215c6a50861f27bd4

Fix: Correct bad vars definition

Issue: RELENG-4563
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: Ie1a1ee5e12cdae56c5108824e3e755a536afd764

CI: Optimize GHA verify job

Issue: RELENG-4563
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I6410121b35edf484a476ae0438c86fc8fbca2d28

CI: Add release workflow for tags

Issue: RELENG-4563
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I32708d17966a7782e65bdf66c152e4e9ac89fda2

CI: Enable sysstat

Test for lftools require that sysstat be running as sar is called

Issue: RELENG-4563
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I0e53f40a36f66a630d8d1a4469e39b811aab951b

CI: Remove python 3.6 checks

GHA default runners will not install python 3.6, remove it as an option.

Issue: RELENG-4563
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: Ia9b54001fb1d6b774796735be0b0a7dde7f70ee3

CI: Add GitHub Actions verify

Issue: RELENG-4563
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I5f37fa7d4cf278d48e4b6eae38f9f477781c36e3

CI: Add tox publish environment

Issue: RELENG-4563
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I5a7158668f3418dbba2d09d71c0d32adbc17ddfe

CI: Add tox build,clean environments

* Add the tox build and clean environments
* Add additional gitignore to deal with build artifacts

Issue: RELENG-4563
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I26df479ac9f0a6177c345fd3a9bdd3dbb4bc9f49

Chore: Clean-up pre-commit issues

Pre-commit issues all need to be clean before GitHub Actions can be
setup.

Issue: RELENG-4689
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I4f08a7ed8f05caaa9430b50bc83aeceb8f4fd71e

Chore: Update pre-commit hooks

* github.com/pre-commit/pre-commit-hooks: updating v4.3.0 -> v4.4.0
* github.com/jorisroovers/gitlint: v0.17.0 -> v0.19.1
* github.com/ambv/black: 22.8.0 -> 23.3.0
* github.com/PyCQA/isort: 5.10.1 -> 5.12.0
* github.com/PyCQA/flake8: 3.9.2 -> 6.0.0
* github.com/pre-commit/mirrors-mypy: v0.971 -> v1.2.0

Issue: RELENG-4387
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I244f85858511ea039e35afddfd05c29b59f7523f

Chore: Use C8 build node for new project creation jobs

ONAP needs to use Centos8 build nodes in new automated project
yaml file creation.

Issue: RELENG-4659
Change-Id: I2dad2d7d26dc0690b98c5c15f42075a46b31fa97
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Chore: rm py2.7 and add py3.8 and py3.9 support

Update the PyPI setup config to remove Python 2.x support
since it is EOL and add support for Python 3.8, 3.9.

Change-Id: Ie7595bbd4a5673bdeef123a34a7d08b73a03d0c5
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix: Remove shade deps from tox

Shade libs are deprecated therefore no longer required
to be installed. Remove whitespaces in EOL.

Issue-ID: RELENG-4644
Change-Id: I06226186cc80d5cb6da41b35f7a9fdf8309bf32d
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix: Replace shade library with openstacksdk

The shade library has been depreciated. Replace shade library
with openstacksdk for remaining openstack commands.

Issue-ID: RELENG-4644
Ref: https://docs.openstack.org/releasenotes/shade/stein.html
Signed-off-by: Bengt Thuree <bthuree@linuxfoundation.org>
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: Ie45f6ba7862a1bd3f471d469286b042512604c54

Merge "Fix: Replace v1 dockerhub api with v2 json files"

Fix: Replace v1 dockerhub api with v2 json files

Signed-off-by: Bengt Thuree <bthuree@linuxfoundation.org>
Change-Id: Iac2e23671bb421745099a1b4cbc56187ab39474f

Fix: Improve parameter handling in os/image cleanup

Issue: RELENG-4467
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
Change-Id: If91463f83c4be698415e695a83f10f416e379dac

Fix: Correct file path and url parsing

These two bugs are both blocking our info-master job, so they are
being grouped together. One is an issue with using an absolute rather
than relative file path when adding a file to git. The other is
parsing the url with safe slashes, which was causing issues with
creation of repos that have slashes in the name.

Issue: RELENG-4461
Change-Id: Ia63ffc5f157bfb5285e8c6bdb2274a91a384a3f4
Signed-off-by: Eric Ball <eball@linuxfoundation.org>

Fix: Mislabelling of function description

Issue: RELENG-4391
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
Change-Id: I65b4b14604c8b536ee5663a43b3b004f701e5660

CI: Enable pre-commit validation via MyPy

Start enforcing proper annotation defintions by way of MyPy validation

Issue: RELENG-4388
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I2776f4f578856da4478637a33711a47a4ba2ef1a

Refactor: Cleanup MyPy errors

While preparing to start enforcing MyPy validation by way of pre-commit
several redeclarations of click command / functions were found. After
examining the errors from MyPy these were determined to be faulty in how
they were being implemented. They were not caught before as no linter
was in place that could easily catch it.

Issue: RELENG-4388
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I35c2502cb08f5502fb30e3d14ac083c30209635c

Chore: Update pre-commit hooks

* github.com/pre-commit/pre-commit-hooks: v4.0.1 -> v4.3.0
* github.com/jorisroovers/gitlint: v0.15.1 -> v0.17.0
* github.com/ambv/black: 21.8b0 -> 22.6.0
* github.com/PyCQA/isort: 5.9.3 -> 5.10.1

* Update tox pre-commit environment to be py37 for base python matching
  our global minver, this is required to get pre-commit to properly
  install under tox

Issue: RELENG-4387
Change-Id: Iffaf00c6100237141140ba5524068964c406c8cc
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

CI: Require RELENG changes in commit messages

To make sure that JSD issues are not being referenced since that is not
public data, we will now start enforcing a requirement that commits have
a RELENG issue associated with them.

Issue: RELENG-4375
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: Ibd30e0f0f1b0ab5393dfd84bf080ab6671936c85

Fix: Bugs in git.gerrit on nexus3 and sanity_check

Issue: RELENG-4366
Change-Id: I88f71ea3ffe746b46a5ee599db99aeee0e9bd3e8
Signed-off-by: Eric Ball <eball@linuxfoundation.org>

Fix: Gerrit create_project check results

The create_project method is not hitting the correct URL, but will
still often receive HTML from the server and a 200 status. We need to
check the validity of the returned data, and use the status of a bad
return as the exit code so that scripts can properly react to the
error encountered.

Issue: RELENG-4355
Change-Id: Icc3a769f0fa9aba61142bef11bd81821e1fa5356
Signed-off-by: Eric Ball <eball@linuxfoundation.org>

Merge "Fix: Print upload size with deploy nexus stage"

Feat: Add get-private-keys to lftools.jenkins

Add ``get-private-keys`` to lftools.jenkins.

The ``get-private-keys`` command retrives the private keys and passphrases
stored in the credential store. This feature will add the
command ``get-private-keys`` in order to print these values.

Issue-ID: RELENG-4245
Change-Id: Iff0cab0b14d43bea540ca513ade08a5e330836e4
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix: Print upload size with deploy nexus stage

Print upload size in the logs after deploying Nexus
stage repositories. This is useful while comparing
the repository sizes.

Change-Id: Ie8cff4ae6e026177cd43c309d4f3a36bab9c7beb
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix: INFO job template and sanity_check call

The INFO job template was improperly formatted. The sanity_check call
is to a class method, and requires and positional argument for "self"
(this does not need to contain anything; it is just filler in this
case).

Change-Id: I1dcbc456bf31e907821ab4c5aee7c324dbd70722
Signed-off-by: Eric Ball <eball@linuxfoundation.org>

Fix: Do not fail tox if gerrit.acumos.org is down

Issue-Id: RELENG-4181
Signed-off-by: Bengt Thuree <bthuree@linuxfoundation.org>
Change-Id: I3a1228e77fd7fdc0ae723c26cff420da8f299fa3

Fix: Force delay (take 2) between docker get calls

Docker has introduced a 429 error return code
if there site is called to quickly.

Retry after 60 seconds after every 429 return code,
up to 19 times. Then fail.

Issue-ID: RELENG-3711

Signed-off-by: Bengt Thuree <bthuree@linuxfoundation.org>
Change-Id: I51d23fa9a2da1dc7cc30afceae4f35942bb42182

Merge "Fix: Force delay between docker get calls"

Fix: Force delay between docker get calls

Docker has introduced a 429 error return code
if there site is called to quickly.

Delay 0.5 seconds after every pull, to avoid to fast requests.

Signed-off-by: Bengt Thuree <bthuree@linuxfoundation.org>
Issue-ID: RELENG-3711
Change-Id: Ic5ac8da65903c0445092d74168ff9fd1dc0068bd

Feat: New method add_maven_config for JCasC config

This method allows for adding settings files for new projects via
JCasC, rather than the old method of using a Groovy script to manually
add the file to Jenkins.

This also removes the __del__ function. The function was not entirely
necessary, and was causing issues with unit testing. All work is done
in /tmp, so these files will be automatically cleaned by the system.

Issue: RELENG-3893
Change-Id: I03511b9c3e1c9f9c9f79054bd6f8991cd274e8f5
Signed-off-by: Eric Ball <eball@linuxfoundation.org>

Feat: Move git functions to use python git lib

Issue: RELENG-4052
Change-Id: Iafaa078b24838135dd67ec0ac53b1d83de13ae8b
Signed-off-by: Eric Ball <eball@linuxfoundation.org>

Test: Speed up Nexus tests

By patching the sleep function, we can remove about 25 seconds of
pauses during unit testing of release_staging_repos method.

Issue: RELENG-4052
Change-Id: I8692c1183d70873348616435074b9b69193dda41
Signed-off-by: Eric Ball <eball@linuxfoundation.org>

Feat: Add get-secrets to lftools.jenkins

Get-credentials only produces username/password credentials, which
does not include "secret text" stores. This feature will add the
command "get-secrets" in order to print these as well.

Change-Id: Iac1911b486be1dc125a42b23595431c7065adfce
Signed-off-by: Eric Ball <eball@linuxfoundation.org>

Fix: Create temp file in empty dirs for S3 log dir

Since S3 buckets does not have an underlying file system to view empty
directories, an temp file has to be created when referencing the directory.
This allows empty folders to be viewed through cloudfront, without
returning a 404 error.

Create temp file in the format: "_%d%m%Y_%H%M%S", would
help with future clean or debugging.

Issue-ID: RELENG-4016
Change-Id: I0a635cd32da860deaada0ac0cc15bf1aa5fc2d4a
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Chore: Configure Flake8 linter

This adds Flake8 to pre-commit and removes the unused config in tox.ini.
Not sure why Flake8 was disabled but config in tox.ini suggests that
it was there at one point.

Change-Id: I93c9a6e4562f957f75f28a3842ae29eb8df67fb9
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Refactor: Resolve remaining flake8 violations

- E304 blank lines found after function decorator
- E402 module level import not at top of file
- E741 ambiguous variable name 'l'
- F522 '...'.format(...) has unused named argument(s): end
- W601 .has_key() is deprecated, use 'in'

Change-Id: I2607e7bb195f6175a7b331e89870fa23e225e31c
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Refactor: Resolve F811 and E712 and E501 in tests

- E501 line too long
- E712 comparison to True should be 'if cond is True:' or 'if cond:'
- E712 comparison to False should be 'if cond is False:' or 'if not cond:'
- F811 redefinition of unused 'test_log_and_exit' from line 26

Change-Id: I896e994b26d62c7bdd85ca61ebf1b9d2df9e8b1e
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Refactor: Resolve Flake8 F401 and F403 and F405

It's bad practice to use * imports (F405) since the methods or
variables being imported could be undefined. Explicitly importing
makes this more clear. Also F403 violation makes it difficult to
detect undefined names.

Additionally F401 violation to allow an indirect module import makes
things harder to debug. It's better to be explicit.

https://www.flake8rules.com/rules/F401.html
https://www.flake8rules.com/rules/F403.html
https://www.flake8rules.com/rules/F405.html

Change-Id: Ib938f865d3ac6456216a119c830d3b013932bf88
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Merge "Refactor: Resolve flake8 E722 bare except"

Refactor: Resolve flake8 E722 bare except

It is considered bad practice to use a bare except as this kind
of except statement can have untended consequences such as disabling
ctrl+c interrupts. At the vary least we should use Exception however
a more specific one would be better. This PR uses the general Exception
to resolve the linter which we can add more specific ones later when
we can appropriately unit test the code.

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I9afcff49f34326d279a63ce972d12f9aa72f18e2

Refactor: Resolve W605 Invalid escape sequence

W605 is deprecated and will become a syntax error in Python 3.8
(https://www.flake8rules.com/rules/W605.html).

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: Ic2a51f089ef9d6fc45a3db5e96a8f5196d59f02c

Merge "Fix: Incorrect indent skips calling deploy_s3()"

Fix: Incorrect indent skips calling deploy_s3()

When Unix style glob patterns are passed through the CLI option
the deploy_s3() function skips the step to push logs to the S3 bucket.

Issue-Id: RELENG-3866
Change-Id: I58d6ef8dab41213fdbc431294ddd21854adc60dc
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Chore: Upgrade pre-commit hooks

* github.com/ambv/black: updating 21.7b0 -> 21.8b0

Change-Id: I4a2374c5e589c4adbfdc9e8e82cb7fc099acaa8c
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Fix: typo in deploy.py

Typo error in xml mimetype deploy to S3 storage. Thais patch remove the
extra sign to correctly map mimetype to content-type.

Signed-off-by: pmikus <peter.mikus@protonmail.ch>
Change-Id: Ia88ac75f483b31312ae72cc104021ab9efda6455

Merge "Fix: Refactor image clean"