From: Anil Belur Date: Mon, 8 Aug 2022 11:58:24 +0000 (+1000) Subject: Fix: Update lf-activate-env code comment X-Git-Tag: v0.79.4~8^2 X-Git-Url: https://gerrit.linuxfoundation.org/infra/gitweb?p=releng%2Fglobal-jjb.git;a=commitdiff_plain;h=19d9b665527b5bc33f8790b6114e71e608306f6a Fix: Update lf-activate-env code comment Fix lf-activate-env code comment. The comment suggests using just the version number ``--python ``, however as per the code the correct format as per the code is ``--python python`` Also update the fix in the 9915b0bb42077428478e2. Change-Id: Ic135036ded75f0b16525ef78bdec9e90c72a5c44 Issue-ID: RELENG-4348 Signed-off-by: Anil Belur --- diff --git a/jenkins-init-scripts/lf-env.sh b/jenkins-init-scripts/lf-env.sh index d0ea6251..a1bd350c 100644 --- a/jenkins-init-scripts/lf-env.sh +++ b/jenkins-init-scripts/lf-env.sh @@ -108,7 +108,7 @@ lf-boolean () { # or # lf-activate-venv lftools # or -# lf-activate-venv --python 3.6 git-review +# lf-activate-venv --python python3.8 git-review # # DESCRIPTION # This function will create a new Python Virtual Environment (venv) and diff --git a/releasenotes/notes/fix-docs-lf-activate-env-a1e6fb274186f86d.yaml b/releasenotes/notes/fix-docs-lf-activate-env-a1e6fb274186f86d.yaml new file mode 100644 index 00000000..fcfac5d6 --- /dev/null +++ b/releasenotes/notes/fix-docs-lf-activate-env-a1e6fb274186f86d.yaml @@ -0,0 +1,6 @@ +--- +fixes: + - | + Fix lf-activate-env code comment. The comment suggests using + just the version number ``--python ``, however as per the + code the correct format as per the code is ``--python python`` diff --git a/shell/logs-deploy.sh b/shell/logs-deploy.sh index 79f8db4f..d797fa7e 100644 --- a/shell/logs-deploy.sh +++ b/shell/logs-deploy.sh @@ -12,7 +12,7 @@ echo "---> logs-deploy.sh" # shellcheck disable=SC1090 source ~/lf-env.sh -lf-activate-venv --python 3.8 lftools +lf-activate-venv --python python3.8 lftools # Ensure we fail the job if any steps fail # Disable 'globbing'