Fix rtd-verify.sh to better validate submodules 78/65678/2
authorEric Ball <eball@linuxfoundation.org>
Fri, 2 Oct 2020 00:52:22 +0000 (17:52 -0700)
committerEric Ball <eball@linuxfoundation.org>
Fri, 2 Oct 2020 01:05:44 +0000 (18:05 -0700)
commit62f08354aaae95b07e6710644d1b7c1e6da8b7bd
tree1902c3a48b11d9c814818e95b47e97529b2b8199
parent53065905f076834d00bfa542c2feeb8553ac177e
Fix rtd-verify.sh to better validate submodules

rtd-verify.sh was using "git submodule" commands to validate
submodules, but Jenkins reads the .gitmodules file and executes a
"git config" command for each submodule. Because of this, if a bad
submodule was added to .gitmodules, it would pass verify but cause
failures on subsequent builds after it was merged.

This change closes that loophole by reading the .gitmodules file, and
then running through the same "git config" command for each submodule
that Jenkins runs when pulling in the main branch.

Issue: RELENG-2932
Change-Id: Ic0e17d23a4763bd52172dad6b98146444bf4c165
Signed-off-by: Eric Ball <eball@linuxfoundation.org>
releasenotes/notes/rtd-verify-fix-606efc9b6387b494.yaml [new file with mode: 0644]
shell/rtd-verify.sh