From da1e6768b06e441f9d0d951eca55ee2c3a74b206 Mon Sep 17 00:00:00 2001 From: pmikus Date: Mon, 23 Aug 2021 10:37:58 +0000 Subject: [PATCH] Fix: typo in deploy.py Typo error in xml mimetype deploy to S3 storage. Thais patch remove the extra sign to correctly map mimetype to content-type. Signed-off-by: pmikus Change-Id: Ia88ac75f483b31312ae72cc104021ab9efda6455 --- lftools/deploy.py | 2 +- releasenotes/notes/fix-deploy-xml-c99387e7b5c4622e.yaml | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/fix-deploy-xml-c99387e7b5c4622e.yaml diff --git a/lftools/deploy.py b/lftools/deploy.py index 183ccddb..c59640b4 100755 --- a/lftools/deploy.py +++ b/lftools/deploy.py @@ -431,7 +431,7 @@ def deploy_s3(s3_bucket, s3_path, build_url, workspace, pattern=None): extra_args = {"ContentType": "text/plain"} text_html_extra_args = {"ContentType": "text/html", "ContentEncoding": mimetypes.guess_type(file)[1]} text_plain_extra_args = {"ContentType": "text/plain", "ContentEncoding": mimetypes.guess_type(file)[1]} - app_xml_extra_args = {"ContentType": "application/xml'", "ContentEncoding": mimetypes.guess_type(file)[1]} + app_xml_extra_args = {"ContentType": "application/xml", "ContentEncoding": mimetypes.guess_type(file)[1]} if file == "_tmpfile": for dir in (logs_dir, silo_dir, jenkins_node_dir): try: diff --git a/releasenotes/notes/fix-deploy-xml-c99387e7b5c4622e.yaml b/releasenotes/notes/fix-deploy-xml-c99387e7b5c4622e.yaml new file mode 100644 index 00000000..b048abc5 --- /dev/null +++ b/releasenotes/notes/fix-deploy-xml-c99387e7b5c4622e.yaml @@ -0,0 +1,5 @@ +--- +fixes: + - | + Typo error in xml mimetype deploy to S3 storage. Thais patch remove the + extra sign to correctly map mimetype to content-type. -- 2.16.6