From d36e19bf1a5f3ffa06df2dfb5ded1101b539adea Mon Sep 17 00:00:00 2001 From: Thanh Ha Date: Sun, 14 Jun 2020 15:12:24 -0400 Subject: [PATCH] Remove dependency on pre-commit lftools has 0 dependencies on pre-commit and thus should not be listed as one of its requirements. lftools simply uses pre-commit as a linter which the dependency is already covered by the tox.ini deps configuration. Commit 54d1936f introduces what seems like an exceptionally large list of dependencies which should be re-evaluated if lftools really depends on any of those packages directly as some of those deps are likely not really deps of lftools. This patch simply takes care of pre-commit as I don't currently have time for a full audit. Change-Id: I18acffc492ba6905e639cdb452dee0c2f5f2fcbb Signed-off-by: Thanh Ha --- releasenotes/notes/fix-reqs-pre-commit-301d30c6f35ed070.yaml | 5 +++++ requirements.txt | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/fix-reqs-pre-commit-301d30c6f35ed070.yaml diff --git a/releasenotes/notes/fix-reqs-pre-commit-301d30c6f35ed070.yaml b/releasenotes/notes/fix-reqs-pre-commit-301d30c6f35ed070.yaml new file mode 100644 index 00000000..e8ce6d95 --- /dev/null +++ b/releasenotes/notes/fix-reqs-pre-commit-301d30c6f35ed070.yaml @@ -0,0 +1,5 @@ +--- +fixes: + - | + Removes pre-commit as a dependency of lftools. This was an unnecessary + dependency as lftools does not use pre-commit at runtime in anyway. diff --git a/requirements.txt b/requirements.txt index d0c6f95a..88d388cc 100644 --- a/requirements.txt +++ b/requirements.txt @@ -25,7 +25,6 @@ multi-key-dict==2.0.3 nodeenv==1.3.5 oauth2client==4.1.3 pbr==5.4.4 -pre-commit~=2.2.0 pyasn1==0.4.8 pyasn1-modules==0.2.8 pygerrit2==2.0.10 -- 2.16.6