From 9782f58bfec1b324e092e17d42674b44797f2a12 Mon Sep 17 00:00:00 2001 From: Eric Ball Date: Thu, 4 Feb 2021 16:11:09 -0800 Subject: [PATCH] Fix rtd-verify submodule update command The old version is missing the "--init" flag, which causes it to not add new submodules. This did not show up as an issue until a new submodule was added in a production environment. Additionally, the "--recursive" flag has been included to ensure proper loading of recursive submodules. Issue: IT-21490 Change-Id: Ie882980d3721ae0e1fea9fa1d3321b86d18be484 Signed-off-by: Eric Ball --- releasenotes/notes/fix-rtd-verify-9af795a7c4c6ecc6.yaml | 6 ++++++ shell/rtd-verify.sh | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/fix-rtd-verify-9af795a7c4c6ecc6.yaml diff --git a/releasenotes/notes/fix-rtd-verify-9af795a7c4c6ecc6.yaml b/releasenotes/notes/fix-rtd-verify-9af795a7c4c6ecc6.yaml new file mode 100644 index 00000000..31d8a491 --- /dev/null +++ b/releasenotes/notes/fix-rtd-verify-9af795a7c4c6ecc6.yaml @@ -0,0 +1,6 @@ +--- +fixes: + - | + The old version of rtd-verify is missing the "--init" flag, which causes it + to not add new submodules. Additionally, the "--recursive" flag has been + included to ensure proper loading of recursive submodules. diff --git a/shell/rtd-verify.sh b/shell/rtd-verify.sh index 29a991b5..e91dd71c 100644 --- a/shell/rtd-verify.sh +++ b/shell/rtd-verify.sh @@ -28,7 +28,7 @@ if [ "$GERRIT_PROJECT" != "$PROJECT" ]; then fi git fetch origin "$GERRIT_REFSPEC" && git checkout FETCH_HEAD -git submodule update +git submodule update --init --recursive for submod in $(git config -f .gitmodules --get-regexp '^submodule\.(.+)\.url' | awk -e '{print $1}'); do git config --get "$submod" done -- 2.16.6