From 4220220db0311237b44efa9bfd0f2288eeedc605 Mon Sep 17 00:00:00 2001 From: Guillaume Lambert Date: Mon, 3 May 2021 15:22:38 +0200 Subject: [PATCH] Add protection in python-tools-install.sh This script may result in unexpected behavior on distributions other than Ubuntu with a matching release. DISTRIB_ID must be tested to avoid such problems. Signed-off-by: Guillaume Lambert Change-Id: I2ba02b613a4aaadfeb09bd66ddfde8f36a9510b4 --- shell/python-tools-install.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shell/python-tools-install.sh b/shell/python-tools-install.sh index 59783053..e0e4eec1 100644 --- a/shell/python-tools-install.sh +++ b/shell/python-tools-install.sh @@ -45,7 +45,7 @@ EOF if [[ -f /etc/lsb-release ]]; then # shellcheck disable=SC1091 source /etc/lsb-release - if [[ $DISTRIB_RELEASE == "16.04" ]]; then + if [[ $DISTRIB_RELEASE == "16.04" && $DISTRIB_ID == "Ubuntu" ]]; then echo "WARNING: Python projects should move to Ubuntu 18.04 to continue receiving support" echo "zipp==1.1.0" >> "$requirements_file" fi -- 2.16.6