From 29db2fd816d8fe8310e208e70ce203be03c53980 Mon Sep 17 00:00:00 2001 From: Thanh Ha Date: Wed, 15 Jan 2020 19:18:18 -0500 Subject: [PATCH] Ignore shellcheck SC2012 use find instead of ls It's reasonable to ignore this here as we're just piping ls to wc to get a file count. The list of filenames is not being parsed in anyway in this case. SC2012: Use find instead of ls to better handle non-alphanumeric filenames. Signed-off-by: Thanh Ha Change-Id: I0687b24816c2b4920893162297cd318f813d7109 --- shell/release-job.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/shell/release-job.sh b/shell/release-job.sh index 55276887..ccaa7824 100644 --- a/shell/release-job.sh +++ b/shell/release-job.sh @@ -384,6 +384,7 @@ pypi_release_file(){ echo "WARN: failed to download source distribution" fi echo "INFO: Checking files in $tgtdir" + # shellcheck disable=SC2012 filecount=$(ls $tgtdir | wc -l) if [[ $filecount = 0 ]] ; then echo "ERROR: no files downloaded" -- 2.16.6