From 8e52d0538f6d9897ea601544a3a22a409b7de20e Mon Sep 17 00:00:00 2001 From: Thanh Ha Date: Thu, 11 Jun 2020 16:47:16 -0400 Subject: [PATCH] Pin importlib-resources version to <2.0.0 The current virtualenv 20.0.21 is incompatible with importlib-resources 2.0.0. This patch pins the version of importlib-resources temporarily until a virtualenv version that supports it is released. This resolves the ignored error in tox-verify job builds: ERROR: virtualenv 20.0.21 has requirement importlib-resources<2,>=1.0; python_version < "3.7", but you'll have importlib-resources 2.0.0 which is incompatible. Issue: RELENG-2993 Signed-off-by: Thanh Ha Change-Id: I04cf74f4209104475c1548653f157821814970df --- releasenotes/notes/pin-importlib-resources-f3fd824b5a84bc8e.yaml | 6 ++++++ shell/python-tools-install.sh | 8 ++++++++ 2 files changed, 14 insertions(+) create mode 100644 releasenotes/notes/pin-importlib-resources-f3fd824b5a84bc8e.yaml diff --git a/releasenotes/notes/pin-importlib-resources-f3fd824b5a84bc8e.yaml b/releasenotes/notes/pin-importlib-resources-f3fd824b5a84bc8e.yaml new file mode 100644 index 00000000..82af123f --- /dev/null +++ b/releasenotes/notes/pin-importlib-resources-f3fd824b5a84bc8e.yaml @@ -0,0 +1,6 @@ +--- +fixes: + - | + Pin importlib-resources to 2.0.0 to resolve package incompatibility + between it and the currnet virtualenv version (20.0.21). Until a + compatibile virtualenv is released this dependency needs to be pinned. diff --git a/shell/python-tools-install.sh b/shell/python-tools-install.sh index eae3c1f4..adcca1c5 100644 --- a/shell/python-tools-install.sh +++ b/shell/python-tools-install.sh @@ -31,6 +31,14 @@ kubernetes niet~=1.4.2 tox>=3.7.0 # Tox 3.7 or greater is necessary for parallel mode support yq + +# PINNED INDIRECT DEPENDENCIES +# ============================ +# The libraries listed below should be considered workarounds and thus need +# to have a link to a JIRA and any relevant pkg versions and support packages +# necessary so that future maintainers of this file can make decisions to +# remove the workarounds in the future. +importlib-resources<2.0.0 # virtualenv 20.0.21 requires importlib-resources<2.0.0 (RELENG-2993) EOF #Python 3.5 in Ubuntu 16.04 workaround -- 2.16.6