Release global-jjb v0.24.0

Change-Id: I5cc5be89985e0fcb99cb256053282b5e740b05c1
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Re-enable CLM jobs

Change-Id: I1816f34e964ff56cba3e5d7af693993c97b1cc7d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Add pre-build step to prep vm before build"

Add option to disable-job for all jobs

Add option to all jobs to allow disabling the job. CLM will has this
setting set to "true" while we figure out the CLM issues however
for all other jobs "false" is default.

Change-Id: I9db6e8603a7d968aacf0eae17dea3554d6c97429
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Disable CLM jobs by default"

Disable CLM jobs by default

Change-Id: I8c3b4a68aaed349d026d08134de4147ea74a9696
Signed-off-by: Jeremy Phelps <jphelps@linuxfoundation.org>

Add pre-build step to prep vm before build

This new build step will run before any jobs run to prep the
builder.

This change should not force using of $HOME/.local/bin just yet
but preps the macros in place for us to activate it in jobs later.
The current virtualenv method should override what's done here.

Change-Id: I55947020e2f0cdbb61f9d4e7e88927d9bc304d17
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Set permit-all true for all jobs

We need this set for all jobs otherwise GHPR will spam GitHub.
This was set for verify jobs but the merge jobs did not have them.

Change-Id: I76db9d6146228180c9af3f06780705dac33b7899
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Move openstack-cron job to global-jjb"

Merge "Require IMAGE_NAME and HARDWARE_ID"

Merge "Add job to verify upstream global-jjb patches"

Merge "Remove mvn-settings requirement from jjb job docs"

Merge "Refactor staging-profile-id out of mvn-parameters"

Merge "Make staging jobs run daily"

Merge "Make maven-merge jobs run daily"

Require IMAGE_NAME and HARDWARE_ID

IMAGE_NAME had HARDWARE_ID are required settings so clearly mark
them as so instead of mentioning the default setting.

Change-Id: I30a00f1c92f7714f7ac8a308d12a6181fe4547cd
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Document the jjb-version variable"

Make maven-merge jobs run daily

Back when OpenDaylight was on Rackspace we were trying to cut back
on how often jobs run due to the infra being unstable and at the
time thought the maven-integration job and maven-merge jobs were
part of the problem. Since we moved to Vexxhost infra has been
significantly more stable and not as big a concern. Let's run
the maven-merge jobs on a daily basis so that project artifacts
have more chances to pass before the 3 week SNAPSHOT clearing
cron that's run in Nexus.

Change-Id: I7ac17b3b4b8729d0f143fb15c71143c3de1ac461
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Make staging jobs run daily

As we move towards more automated releases having regularly running
staging jobs will allow projects to discover broken staging jobs
earlier. Let's run these jobs @daily as a default.

Change-Id: I50a3f27396fc921714d1faff16830b2e6b38730d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Refactor staging-profile-id out of mvn-parameters

This was originally a bad design decision. We should not be forcing
staging-profile-id variable against all users of
lf-infra-maven-parameters when only the staging job needs it.

This patch moves custom parameter definitions to the maven-stage job
and removes staging-profile-id requirement from all other jobs.

Change-Id: I58fe4c43c851cd9e61ddec847529b0dcb91e0af1
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Allow unbound variables in sigul scripts

These scripts as they are designed expect unbound variables so
enable them at least until they are fixed.

Change-Id: I48182a1d5d5c3cf4d42249bfc8a55b7c0088ec36
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Use include-raw instead of escape for sigul macros

These macros are not using any substitutions so are hitting
the bug that inserts curly braces.

Change-Id: I7af376c3c4ce1e2cd41ca4842e5042728cdafb69
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix typo in lf-sigual-install builders syntax

Change-Id: I8a75a63a577500783d7a5f22f1833a2f6451f3d5
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Move openstack-cron job to global-jjb

Move OpenDaylight's builder-openstack-cron job to global-jjb. This is
an initial patch that only migrates the "image-protection" script.

image-protection is used to parse jenkins-config/ and jjb/ directories
for any mention of images starting with "ZZCI" and flagging them as
protected. The assumption here is that ZZCI images are CI managed
and if they are referred to anywher by anything then they are
effectively considered in-use and should not be deletable so flag
them as "protected: true" in OpenStack.

Change-Id: Ib706663f0c08bd7a9160b0a6ce69dcd3b802f8f5
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add job to verify upstream global-jjb patches

Add job that can be used by downstream projects to report upstream
to global-jjb patches when a proposed patch breaks their project.

This job sets -1 CR only and does not block the upstream patch as
there are cases where we may want to break backwards compatibility
on purpose. This job's purpose is to give us a clear view when it
does happen.

Change-Id: If0dda88ff24da7fd171484c37855f33b05f36553
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Document the jjb-version variable

Change-Id: Ia07cb6b437e6e2107b8301d52f72aa3cace112da
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Remove mvn-settings requirement from jjb job docs

These jobs do not use that setting.

Change-Id: I8c606002bc4ca187b56514d65aa39919a6c6e74b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Add Jenkins Sandbox Cleanup job"

Merge "Rename maven-release job to maven-stage"

Merge "Make GHPRB trigger on comment only"

Make GHPRB trigger on comment only

Issue: RELENG-1132
Change-Id: I5d67b8a70a4b2d5dc5e7c4028ba62c21cd7a7d1e
Signed-off-by: Jeremy Phelps <jphelps@linuxfoundation.org>

Test with latest JJB and supported JJB

Test global-jjb with both the latest version of JJB as well as the
global-jjb supported version of JJB.

Also include a script to ensure that jjb/lf-ci-jobs.yaml and tox.ini
define the same supported versions of JJB.

Change-Id: I1a181776c6d0eef1b857ede9099d3ebb8e3ba98d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Upgrade minimal jjb version to 2.2.1

Issue: RELENG-1129
Change-Id: Idd342b85a0306cfedb63215f4a6442ced74c94e4
Signed-off-by: Jeremy Phelps <jphelps@linuxfoundation.org>

Add Jenkins Sandbox Cleanup job

This cleanup job runs weekly on Saturdays to clear out Sandbox
jobs and views from the system.

The benefit of this is that it uses the same version of JJB as
the other CI jobs whereas the traditional cron job we put in puppet
does not often get updated to match the right version.

Issue: RELENG-1118
Change-Id: I2229d66f637bd5aab203a3bbf12aa1e677a471a1
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix packer {cron} should be {obj:cron}

Cron accepts a multiline list of crons so fix to {obj:cron} so that
the user can provide multiple cron settings.

Change-Id: I2ac03ad59e33c07eaa0a89d87bd7486fdbfe7e9d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Add CMake Stage job"

Rename maven-release job to maven-stage

ATTENTION: This is a breaking change. The trigger word
"build release$" is changed to "stage-release$" to better
reflect what this job is actually doing.

In preparation for work on RELENG-425 this change renames the
maven-release jobs to maven-stage job to better reflect what the
job really does.

Trigger keyword was also changed to "stage-release$"

Issue: RELENG-425
Change-Id: I0dd4342664251386ddc7eca52df56156105f200d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix nexus-iq-scan-patterns should be obj class

Since we are passing a list we need to set the scan patterns
variable as {obj:var}.

Change-Id: I13c4cf4d77f8aee0652962731a5bd7fb901a3d46
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add CMake Stage job

Issue: RELENG-1108
Change-Id: I6b295c1ceefc1c77fbe3311a8fdf314849b35cd0
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Document comment triggers

Change-Id: If017ac0989557cef10f2d393bddf98d40b7d9121
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add github whitelist branches params to trigger.

Issue: RELENG-1104
Change-Id: I02c7d8926888f17e8b9b7d78deb561147f44602f
Signed-off-by: Jeremy Phelps <jphelps@linuxfoundation.org>

Fix github project url for properties

Jobs will not trigger off of GHPRB without it.

Issue: RELENG-1103
Change-Id: Id35c7e4f4beb5ecc06a69ac2c684cd585b565fae
Signed-off-by: Jeremy Phelps <jphelps@linuxfoundation.org>

Merge "Update CLM job to use Nexus Policy Evaluation"

Update CLM job to use Nexus Policy Evaluation

Depends on JJB plugin support:
https://review.openstack.org/584581

Change-Id: I9b790183545f64c2d535163ae0eed9ed1ad5cc1e
Issue-ID: RELENG-1086
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Release global-jjb v0.23.0

Change-Id: I2f9edd302f643601c18bb02ad08e79c5faf7f316
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Use eval so that $cmake_opts is properly parsed

Without eval bash inserts single quotes and breaks parameters passed
if they have quotes in the parameters. For example
`-D CMAKE_CXX_FLAGS="-fPIC -std=gnu++11"`

Issue: RELENG-1075
Change-Id: I77046a7edc0516f0ae28dd2b8cd2c8994ad5079e
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Validate only template/platform that is built"

Validate only template/platform that is built

No point validating every combination of template/platform in a
merge job that is only interested in building a single combo.

Change-Id: I0ad760b3247ac18aba79a9bca25d887e09b987fa
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix GitHub templates override lf-infra-properties

When redefining any Jenkins section we must redefine everything
that is being overrided otherwise previous configuration will
be lost. This patch fixes the build-days-to-keep parameter that
is lost in the GitHub jobs due to the github property override.

Change-Id: I8a127344189215367c3546d0b3222d989ea74800
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add cmake-verify job template

CMake verify job template for building CMake based projects.

Issue: RELENG-1074
Change-Id: Iccd3bab1d9f17071583a03e84b35bcd729161195
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Add Node / NPM cache & metrics to .gitignore"

Add Best Practice for Shell scripts

Change-Id: Ia6370964e34af94eceb9797596a048a5df3aea2a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add Node / NPM cache & metrics to .gitignore

Change-Id: I7eaff8749e45c1699da0000ba4f446c4f37d3df8
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix global-vars fail to instantiate instance

Not sure why this is suddenly a problem. Jenkins was not upgraded
as far as I am aware but adding Jenkins. seems to resolve the
issue we suddenly started seeing.

Change-Id: I76b7e01c7f1d377e7c4b63d5adde1b4fc29c6933
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add global-jjb v0.22.0 release notes

Change-Id: I763e15fc63482d51a2f6a7878641c5738b881e30
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "project-pattern configurable for license-check"

Merge "Remove Unused Jenkins-Admin Groovy Scripts"

project-pattern configurable for license-check

Allow the project-pattern to be configurable for the license-check
job. In an ideal world we would have have a single job that will
enforce for all projects but initially we will need flexibility to
allow us to adjust as we enforce against existing projects.

Change-Id: Ibf83868bacf520c69ef729566207ce7cc7ecf57e
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Support recheck and reverify in global-jjb"

Pull default USER_DATA_ID from cloud.cfg

Sets the default USER_DATA_ID for minion templates to be
what is defined in cloud.cfg. If cloud.cfg does not define
one then default to "jenkins-init-script".

RELENG-1069
Change-Id: I135c9a6c1d0ee11e627a66d1cc87e60eb7db1b20
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Sigul install location has changed

The location to install sigul from has changed since initial testing was
done.

Change-Id: I911d748aa662d68bcc1e4ecc304b04268dc995d7
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Pull default KEY_PAIR_NAME from cloud.cfg

Sets the default KEY_PAIR_NAME for minion templates to be
what is defined in cloud.cfg. If cloud.cfg does not define
one then default to "jenkins-ssh".

Issue: RELENG-1066
Change-Id: I72bddf861174139048e1843a3631b3998ac32bef
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add support for JNLP based minions

Issue: RELENG-939
Change-Id: I05a4fa92387425932bbc28cadadbb44acbc190bb
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Revert "Print out OS Cloud Plugin version"

This reverts commit dfb2c6ca52a4c885e42d6c2252706bd824c75068.

Change-Id: If217ac6caf7b33c54e61d3a090c1062c666e63b9
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Support recheck and reverify in global-jjb

In OPNFV we are using reverify as a convention (we also support recheck)
This was previously deprecated in global-jjb
But I'm adding it back to not confuse our users

Change-Id: Ie794636e49f97ff2ac2735e81c407b57a3470f55
Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>

Make toxworkdir configurable and default to /tmp/v

By default tox environment will now be installed under /tmp/v/{envname},
but configurable through the CLI environment by specifying TOX_WORK_DIR.

This will allow users dynamically specify where the toxworkdir should
live, like so:

> TOX_WORK_DIR=$(mktemp -d -t gjjb-XXX) tox -e ...

Change-Id: I3daa4dc3538c61fb80a464a1b7e07d7b48fd7a1c
Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>

Document support for os-cloud-plugin 2.37

Change-Id: I4ea15a75d6f98ac95bf352fe0b7ca386e6874723
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Print out OS Cloud Plugin version

Change-Id: I974667afb03f5aa4a00c4098ce93ca96c4a388ec
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix API breakage caused by OS Plugin version scan

Patch I3384c86c64c3aff7404ddec77aa85463e5fbac2a caused an unexpected
API change in get_minion_options which now requires a $silo
variable. However the change was not passed down to all instances
where the function was called causing breakage.

Change-Id: If4a0cec0232d1381413da3f6279f23bc426e1ace
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Update build-timeout parameter documentation

All build-timeout documentation incorrectly lists seconds instead of
minutes, while the the license scanning jobs did not have build-timeout
documented, and the packer merge job had the wrong value listed.

Change-Id: I6e3f2b934bcda92fb14ab9cd996434ff83277408
Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>

Document support for OS Cloud plugin 2.36

Change-Id: I662e1a479f10d9040eb75dd5a29c0c0b25d0dcf8
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix empty  variable when run in Jenkins

Change-Id: Ic6e2b1424e8e59611e021c4a506ba556e8e2111e
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge changes from topic '10422'

* changes:
  Enable ensure-documented check
  Document undocumented macros
  Document undocumented ci-jobs macros
  Document undocumented maven macros

Merge "Document undocumented Python macros"

Merge "Add license check job using new lhc"

Merge "Add support for OS Plugin v2.35"

Merge "Use a more exact grep for fetching cfg options"

Merge "Global-JJB Jenkins scripts require recurse"

Global-JJB Jenkins scripts require recurse

If a project is switching to using the global-jjb provided
jenkins-init-scripts then the clone that they need to do requires that
they do a submodule recurse clone.

Change-Id: I748205f58b016e27bdd1c95df6b67d47b16bb6aa
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Merge "Support Windows Scripts in JJB and Packer Jobs"

Merge "Make version string optional."

Merge "Remove extra parameter quotes"

Support Windows Scripts in JJB and Packer Jobs

This change enables verification builds to be triggered for changes to
Powershell and Batch scripts in jenkins-job-builder repositories.

Change-Id: Ifb8ca3a59cce116b3a41cb143f080c5a4d488646
Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>

Make version string optional.

versions is not yet documented for INFO.yaml
We do not yet have version in OPNFV's INFO files.

Change-Id: I1aa2f4a323fe9296bf9bfdc3a1d9043e32d24b8f
Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>

Enable ensure-documented check

This script is a dumb script that checks that there is an equivalent
marking in docs/ for each yaml section. This patch also resolves a
bug in the script where it was not detecting all undocumented items.

Change-Id: Id33c8eae06e47256d53457eaa57c21cf7634ee19
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Document undocumented macros

Change-Id: I1726c5c122a2d4b73d17f62dc9f3458f1ab8d731
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Document undocumented ci-jobs macros

Change-Id: Iad4d692f393802716378dabc9770ba0f38967d92
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Document undocumented Python macros

Change-Id: I597822be7e47373efb407ca6ff3b0a788b784c76
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Document undocumented maven macros

Change-Id: I1c052e377402080adca951e3f785ac795e08b124
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Rvrt "Add pre-commit hook for trailing-whitespace"

This reverts commit f325f0dc4d34cb79e9c15813140db1e18ed2a185.

Change-Id: Iaf8fbe8a9760670bd7dc94da89e1cac145be8fb4
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix missing parameters in tox-verify job

Patch If2edba598b47484b1708f1e0f3fb96f035511841 broke parameters in
the tox-verify job by overriding all the existing parameters with
only the PARALLEL parameter. This patch fixes it by moving the
parallel parameter definition so that it is declared along with
the other parameters the job requires.

Issue: RELENG-1042
Change-Id: I6fdd8876235843101bc175ff91ed872aab88279d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add license check job using new lhc

Create a job using
https://gerrit.linuxfoundation.org/infra/#/admin/projects/releng/license-checker
as the license checker tool for projects.

This job is meant to be managed by LFRE to ensure projects are
providing the appropriate license headers.

Change-Id: I5ca6da61dc6ee250a2c6d451b09a0075fb1ff0b0
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add support for OS Plugin v2.35

The SlaveOptions() API in OS Plugin v2.35 was changed to include a
new minimum instance cap configuration.

Issue: RELENG-1041
Change-Id: I3384c86c64c3aff7404ddec77aa85463e5fbac2a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Use a more exact grep for fetching cfg options

Use an exact grep command to fetch cfg options so that an
option containing the same characters in another option does
not get parsed accidently.

Change-Id: I40f3fd883ab5245da35b911aef3fe9edbda88fe2
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add pre-commit hook for trailing-whitespace

Install using tox:

    tox -e check-hooks

ref: https://pre-commit.com

Change-Id: Ie060a9d1c843ce3889df10535d0a87e41d4b4e76
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Change project to clone by jjb-deploy

When "jjb-deploy" is invoked from a gerrit patch, we do not
want to clone the patch project code ($GERRIT_PROJECT) but
the releng/builder code ($PROJECT).

Change-Id: I329b3c756826250358b20aeb2454cb5650d87f59
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Remove extra parameter quotes

The quotes should only be used in place where the macro
is called.

Change-Id: Ia76a113aa5cb2d07577d099be5585e4530bdeaf5
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Release global-jjb v0.21.0

Change-Id: Ia9cdcfe2112ee60499c6ba35f959dc1e169b8220
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Remove unnecessary github trigger macro

This trigger macro was essentially redefining everything the trigger
directly supports. We might as well just call the trigger directly.

Change-Id: I1fc77b501678f213767a70c99119a56a418910fc
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Set minimal packer version to 1.2.3

Patch Ia195bd99d55f23b4f39acf590520637e54fc006a introduced
`instance_name` which requires a minimum Packer version of
1.2.3 in order to be used.

ref: https://github.com/hashicorp/packer/blob/v1.2.3/CHANGELOG.md

Change-Id: I6219855f8de35519f1ea07cc04385acf91bf90f1
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>