Merge "INFO validate job improvements"

Add Sonar plug-in configurations to docs

Add documentation for configuring the Jenkins Sonarqube Scanner plug-in.

Signed-off-by: Houa Yang <hyang@contractor.linuxfoundation.org>
Change-Id: I21b21efc6cefa3f4f643a0235d670c6e1ec4ac08

INFO validate job improvements

removed +x trace as job is too verbose

verify now checks that repositories matches $PROJECT
Catches projects that replace / with - in their INFO file
Also ensures that repositories only has one entry.
We are not supporting multiple projects with a single INFO.yaml
file.

ISSUE: RELENG-2344
Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
Change-Id: Id847b7c10ef0515fd6f6a4b7d6809ebd37a9b51d

Merge "Remove detox in favor of tox --parallel"

Update lftools version to v0.26.2

Change-Id: I069dda979d203b1960821e4d112a5591843fd441
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Add DRY_RUN param to the release job

Add DRY_RUN build param to do a test run the job with
publishing artifacts.

Change-Id: I1b015db4be8ed3e8c39bec2cefe022819e31e59f
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Merge "Verify both repos before attempting release"

Verify both repos before attempting release

We have run into a case where the repo on ODL
was good, and the repo on nexus was failed.
Cover this case by running the loop twice.

Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
Change-Id: I995a34918481db9e41d5486c06995f57100c1199

Remove detox in favor of tox --parallel

Tox officially supports parallel mode as of Tox 3.7 so drop the
usage of detox. Set parallel mode to 'auto' which will run as many
threads as available CPUs.

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: Id59ad10ed9b521a5c0ca3fef3e7e15053c2dc32c

Fix cmake docs

Remove unnecessary info for :install-prefix parameter.

Issue: RELENG-2210

Signed-off-by: Houa Yang <hyang@contractor.linuxfoundation.org>
Change-Id: I6cebee91b62f240c9cd8ade4b80573621b060ef0

Configure basepython to python3

More and more libraries that we are pulling in require Python 3 so
to avoid having to play the pin dependencies whack-a-mole game let's
bump or base python where possible to python3.

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I65208f80b9f0479a10b1a8b6a4ba52956c2c3e3c

Upgrade lftools to v0.26.1

Change-Id: I66a72fcb7cff0148eb0f680df13e8744b17c7025
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix use-release-file varaible

Rename "RELEASE_FILE" parameter to "USE_RELEASE_FILE" in
release-jobs. This will match the actual varaible default value
better and will not collide with the local "release_file" in
the script.

Fix "USE_RELEASE_FILE" if statement. We are now using a bool
instead of a string.

Changing the if statements to evaluate bools.

Change-Id: I9909a16487fabacc0261f6489ac81a00cbf0f965
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Pin more-itertools~=5.0.0

Pin more-itertools ~= 5.0.0, since version 6.0.0 requires Python 3.4
https://github.com/erikrose/more-itertools/releases

Error:
more-itertools requires Python '>=3.4' but the running Python is 2.7.5

Pin tox~<3.5.0

Change-Id: I1f2eefefc3f5b58a14441db78fb3f0bf9061e711
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Merge "Add pre-build scripts to Python templates"

Add support for container releases

- Add support for distribution_type container
- Add conditional build step.
If {build-node} is ^.*-docker-.*
docker login will occur for verify and merge.
- Trigger updated to support hidden releases
directory. (releases\/.*\.yaml|\.releases\/.*\.yaml)
- Container support:
    container_release_file example:

        containers:
            - name: example
            version: 1.5.1-20190806T184921Z

    - Verify pulls container
    - Grab the image_id
    - Merge
    - Apply tag
    - Push the container

ISSUE: RELENG-2292
Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
Change-Id: Ibc6cf1a22bd6c0136a94d2b434c6cd332c12b43f

Add pre-build scripts to Python templates

New parameter pre-build-script accepts a shell script
that can install prerequisite libraries, rearrange the
source tree to cope with nested projects, etc.

Change-Id: I1fd7c2c094a664244e697ff5a61b82a2e7752faa
Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>

Merge "Add lf-sonar-common job-template"

Merge "Allow Build with Params releases"

Allow Build with Params releases

Add support for "Build with Parameters" for projects
that do not want to use a release file for maven builds.
Restructure shell/release-job.sh into functions.

Change-Id: Iada9c9a50710c24fbfe87b2ea0def10f3dd04bd7
Authored-By: Aric Gardner <agardner@linuxfoundation.org>
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Add lf-sonar-common job-template

Add lf-sonar-common job-template for sonar-project.properties

Issue: RELENG-1304

Signed-off-by: Houa Yang <hyang@contractor.linuxfoundation.org>
Change-Id: I6788bf9afb3b25fb751b806f08fddcf2fed42d26

Fix release-schema.yaml

Fix missing extension in ID for release-schema.yaml.

Make "distribution_type" mandatory in future
release files.

Change-Id: I813f6b863fabfafcc9560df753c380675e8cc09e
Co-Authored-By: Aric Gardner <agardner@linuxfoundation.org>
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Merge "Upgrade lftools to v0.26.0"

Merge "Update packer-version to 1.4.3"

Hard code release job compare pattern.

This change:
https://gerrit.acumos.org/r/c/ci-management/+/4979

The project section has:
gerrit_trigger_file_paths:
  - compare-type: REG_EXP
  pattern: '^((?!migrate-cms-to-cds|\/COMMIT_MSG).)*$'

This is overwriting the default parameters of this job.

gerrit_trigger_file_paths:
  - compare-type: REG_EXP
    pattern: "releases/*.yaml"

I belive I should hard code this value so that this
does not happen.

Pattern going forward will actually support
pattern: '(releases\/.*\.yaml|\.releases\/.*\.yaml)'

I will update 16470 and hard code as well, if this is
merged.

ISSUE: RELENG-2316
Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
Change-Id: Ib520672a548f34762c723972152abea898cd98a8

Update packer-version to 1.4.3

This new packer version fixed an issues in
docker image, where its unable to install the
packages into docker containers due to checking
of wrong container OS.

Fix in 1.4.3:
builder/docker: Check container os, not host os,
when creating container dir default [GH-7939]

Issue: RELENG-2180
Signed-off-by: Suresh Channamallu <schannamallu@linuxfoundation.org>
Change-Id: I3fe36e5669942d1f7fadfd2b711f9d7a3ca1e5a9

Upgrade lftools to v0.26.0

Change-Id: Iaa97109a097a85d0847372b8d7c9515960a4cd2e
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Update release-jobs docs.

Feedback has allowed me to
Clarify the procedure

Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
Change-Id: I421cb6eebfccb48bde02d2a9d75ff020f895fde3

Merge "Resolve ShellCheck errors in shell scripts"

Use --config-xml option for JJB archives

The --config-xml option will produce actual config xml files in the
format 'job_name/config.xml' similar to the jobs directory in Jenkins
master instead of creating generically named 'job_name' files.

This allows the jobs to be dropped into a Jenkins jobs directory
path and Jenkins will be able to pick it up.

This is potentially useful for the ability to quickly drop in the
config into a Jenkins test environment.

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I59517d905a2448e46c50d98a471e10d7ca0fb808

Resolve ShellCheck errors in shell scripts

* SC2086: Double quote to prevent globbing and word splitting.
* SC2027: The surrounding quotes actually unquote this.
          Remove or escape them.
* SC2016: Expressions don't expand in single quotes,
          use double quotes for that.
* SC2236: Use -n instead of ! -z.
* SC2233: Remove superfluous (..) around condition.

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I73207aa87646472bdb1c7848ba9608ac702bda53

Merge "Use release credentials only for merge job wrappers"

Merge "Spell check fixes in release-jobs docs"

Use release credentials only for merge job wrappers

Release creds are only required for promoting the repo, which uses diff ACL
as compared to normal user.

Therefore dont use the release creds for the verify jobs and the
scm sections in both the job templates.

Issue: RELENG-2129
Change-Id: Ibb36d11ba57c5e59a63c414b0b338846eefd8983
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Had an if where I needed a fi

Also the git fetch needs the dashed version
git fetch "$PATCH_DIR/${PROJECT//\//-}.bundle"

Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
Change-Id: Ib4245be2b46645fca93225a5c32efb904acd68c8

Upgrade lftools version to v0.25.4

Change-Id: I10460e230bccbf69cf8e8e12244f6c7a88cdccca
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Spell check fixes in release-jobs docs

Change-Id: I76aacf289bd46a1578c0741d58f2f3be4f48f28f
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Exit 0 if release job has already tagged a repo.

The release merge job is a one way operation.
Given this, Release jobs should only exist in the format
{project-name}-release-verify
and
{project-name}-release-merge

They should trigger from a change to any branch/**
As a developer working on {example-branch} will not want to
check out master to push a new release file.

Edge Cases:
Inevitably a release file will be pulled in from master to {example-branch}
or a remerge will be requested
This will again trigger the release jobs.
since in this case the repo is already tagged, the job should not report
a failure.

This is solved by having the verfiy and merge exit 0 when the repo is already tagged

if git tag -v "$VERSION"; then
  echo "Repo already tagged $VERSION"
  echo "This job has already run exit 0"
  exit 0
if

Example Workflow - Milestone 0 is released from master:
releases/1.4.0.yaml (on branch master)
tag: 1.4.0
log_dir: 'optf-osdf-maven-stage-master/97/'

Repo is tagged and artifact is pushed!

Milestone 3 is released from dublin:
releases/1.4.3.yaml (on branch dublin)
tag: 1.4.3
log_dir: 'optf-osdf-maven-stage-dublin/20/'

Repo is tagged and artifact is pushed!

Note:
the ref is determined by the log file.
So We could check if this ref can be found on the {branch}
to reduce human errors.
example:
odlparent-maven-stage-4.0.x/152/patches/taglist.log.gz
has:
odlparent c8964051cf81e2bd5d831fe6e5d568c5eedeeb8e

Psudo code:
STREAM=${STREAM:-'nostream'}
echo "--> Checking if $ref is on stable/$STREAM"
if ! (git branch -a --contains $ref | grep "stable/$STREAM"); then
    echo "--> ERROR: $ref for $repo is not on stable/$STREAM!"
fi

Also in this patch:
To reduce possible errors:
Don't get project name from the release file:
PROJECT="$(niet ".project" "$release_file")"
we can just use ${PROJECT//\//-} when we need
the /'s changed to -'s

It will allways be correct when passed to jenkins
from gerrit

Also remove quiet from wget,
if there is a failure I want to see it on the console.

Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
Change-Id: I1e95e864bc2b49a62b3f7016cb2f1292a6687d9a

Merge "Add release notes for lftools v0.25.3 release"

Improve the release job script

Change-Id: Ie62e2f3771632012423e0b791aca1551b4b31112
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Update the release job tigger

Update release job template to tigger on any branch name, and not just
'**/master'. ODL projects branches are version '4.0.x' which requires
passing the branch name to the template.

Issue: RELENG-2129
Change-Id: I9c29d1c986fee73f6bad4fe39af8f9ffbda201c6
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Add release notes for lftools v0.25.3 release

This was missed in CR Id64b36e8f59d500800d6b9078f56b314348ed1f2

Change-Id: Ie5412ea5724db51fe1eb73fd5f9370b2b6e3b6d2
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Verify job needs target/variable switch

Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
Change-Id: I46501ed93f873c87a7d297398c1eb0dc9d23700f

Fix release-job.sh

Use {GERRIT_PROJECT} when calling Gerrit in
release-merge job.

Change-Id: I0d62d5c713858e7e43b2fc6a6462813b01bea2f8
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Fix signing pubkey declaration

Change-Id: Id9fb1cfa8c992949266622e3a2ed2100e8bc78f6
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Merge "Update lftools version to v0.25.3"

Handle multiple repos listed in staging-repo.

Handle multiple repos listed in staging-repo for ODL.

Also multiple release files in the same commit will not work.
exiting if this case is detected

Also
git diff HEAD^1 --name-only
is bad. if there is another merge it fails.

Change to
git diff-tree --no-commit-id -r $GERRIT_PATCHSET_REVISION \
    --name-only -- "releases/"

StrictHostKeyChecking is enabled on the builder.
disabled

Also needed to change

{jenkins-ssh-credential}
to
{jenkins-ssh-release-credential}

Also
Give group ``self-serve-release`` Forge Committer rights
on refs/tags/
and allow on Create Signed Tag Create Annotated Tag

Also
- file-id: signing-pubkey
target: SIGNING_PUBKEY

Also fix nexus url needs https://

Issue: RELENG-2129
Change-Id: I55dc0a4022f93a6c3c0f389c04c88c38c53eff64
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Update lftools version to v0.25.3

Change-Id: Id64b36e8f59d500800d6b9078f56b314348ed1f2
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Add upgrade information

Add upgrade information for commit
729b2e3535f009a146719df7d7b52e036b2505cb

Change-Id: Id27a14aaff31153dad534794ef70534d0bfe8bf7
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Import the pubkey and check the tag

with git tag -v $VERSION

Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
Change-Id: I954dfa1c8ca09f64ff8a35c138290565de8de4b9

Project pattern was incorrectly set to **

must be {project}

Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
Change-Id: Ic2db72185a3b2e2eb22011b2bc5e8f6012c235c3

Merge "Self serve release docs"

Self serve release docs

And code fixes for new:
jenkins-ssh-release-credential

Fix in release-job.sh
These were overlooked for merge:

git config user.name
git config user.email
gerrit_ssh=$(echo "$GERRIT_URL" | awk -F"/" '{print $3}')
git remote set-url origin ssh://"$RELEASE_USERNAME"@"$gerrit_ssh":29418/$PROJECT

Also included a small capitalization fix in lf-info-vote.rst

ISSUE: RELENG-2127
Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I11ad122153d71a3d25d6b8839e09435f8b27b19d

Merge "Log $JOB_NAME with the jjb-deploy"

Merge "Update lf-info-yaml-verify"

Log $JOB_NAME with the jjb-deploy

Change-Id: Ifb2715402dc1dcb21708e4dc8851e0c621d59145
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Merge "Consolidate lf-infra-jjbini with JJB 2.0"

Consolidate lf-infra-jjbini with JJB 2.0

There is no need to have two separate versions of the
macro anymore since we are already on JJB 2.0

Change-Id: I2295489f8d0bebf9e1628db91c38e74d3839b8a0
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Update lf-info-yaml-verify

Move info-schema to schema/info-schema.yaml
to keep schemas consistency.
Download only needed files for lf-info-yaml-verify
rather than cloning the entire repo.

Issue: RELENG-2242
Change-Id: Ie135c761d1401957be33c98634467967cc085ce2
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Merge "Extend sonatype-clm.sh goals"

Fix wget release-schema.yaml

Download raw version of release-schema.yaml to
compare against release files using lftools.

Issue: RELENG-2131
Change-Id: I82b505260ff172ddb47ad0e58e8721f91ed98581
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Fix release-job.sh Nexus proxy var - 2

Avoid the usage of project specific variables.
Do not use ODLNEXUSPROXY var, but instead use
a generalized variable.

Commit 118b7cbf171aca498d1a0a3a485bad990ad2e7b6
missed this variable.

Issue: RELENG-2131
Change-Id: I3adee1f41616495aab3afe262e8fa70902d619f7
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Extend sonatype-clm.sh goals

Allow to configure maven goals in
lf-maven-clm to allow running test in
some projects.

Issue: RELENG-2236
Change-Id: I83c0efb8b3749483554bf4c1db04ea77c2d17cd7
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Update staging jobs triggers

- Allow lf-maven-stage jobs to be triggered
using either "stage-release" or "stage-maven-release".
- Allow lf-maven-docker-stage jobs to be triggered
using either "stage-release" or "stage-docker-release".

Change-Id: I133063d0cf99ab9b6a06b452ac392959bc678b39
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Pin numpy to 1.16.4

numpy numpy-1.17.0 requires python 3.5

Change-Id: I4bfffcf2bd7b4cf8c9246d15b6fbe819d86e695d
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Merge "Add packer image $NAME in description setting"

Upgrade wss-unified-agent

Upgrade to the WhiteSource Unified Agent
version 19.7.1.

Issue: RELENG-2237
Change-Id: Iac87fc09597a79586718cc3b07ec7034e4a95c13
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Add packer image $NAME in description setting

Add packer image $NAME in description setting so that the image name
is displayed above the job logs URL. This saves a little time from
looking for the image name in the console logs.

Tested:
https://jenkins.opendaylight.org/releng/view/packer/job/builder-packer-merge-centos-7-builder/57/

Issue: RELENG-2230
Change-Id: Id86ee9795e1bfd50850c4833fc6f90545367f113
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Merge "Add option to pass JAVA_OPTIONS"

Add option to pass JAVA_OPTIONS

JAVA_OPTIONS are required to execute sonar jobs
Currently there is no options to pass this variable
so adding this option to pass from the project.yaml

Issue: RELENG-2152
Signed-off-by: Suresh Channamallu <schannamallu@linuxfoundation.org>
Change-Id: I0842f222fc7abf11b258b0691167b701bb319458

Fix release-job schema and central url

Perform "lftools schema verify" command to validate the release files
against schema/release-schema.yaml
Obtain optional maven central URL inside the loop that scans release
files.

Issue: RELENG-2131
Change-Id: I6af1cbb32f25ad33385bac176dc57021d94a5043
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Merge "Fix release-job.sh version var"

Fix release-job.sh version var

Allow only semantic release versions like
"v${SEMVER}" or "${SEMVER}".
Fail the script if the version is not valid.
Do not append any additional characters to the
release version during tagging and pushing steps.

In this case, if the user wants to use the prefixed
"v", they can define it in the releases/*.yaml as:
version: 'v1.0.0'

Issue: RELENG-2131
Change-Id: I71f32600d3e17ec117776be6764c2e45ee934bdd
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Merge "Set $JAVA_HOME for openjdk12 on CentOS7"

Use prettier for automatic formatting for YAML

No more debate on style formatting, prettier is an opinionated
style formatter that will automatically format to the right
style.

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: If9aae2087c3299ae5d54728cd17d86c2b0dcb8a0

Fix formatting to prettier style

Refer to If9aae2087c3299ae5d54728cd17d86c2b0dcb8a0 for details
on the implementation.

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: If845d7ecf8ee229bdd2407038cfe6bb0e2a9194f

Add release-schema

Add schema file used to verify releases yaml file
contents during lf-release-jobs

Issue: RELENG-2131
Change-Id: I8466269333f6f6597ee2a3b1c55b3140c1ea1e23
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Merge "Standardize "release" wording"

Set $JAVA_HOME for openjdk12 on CentOS7

Issue: RELENG-2202
Change-Id: Ib2a53613bfb3b6f1ee388d2f621356b1cefb185e
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Merge "Add workaround for javadoc verify jobs"

Merge "Fix script indent to 4 spaces"

Merge "Handle stack removal with the force option"

Standardize "release" wording

Using "releases" and "release" in different places
is becoming a little confusing. Standardize to "release"
to match lftools command and the majority of the exisiting
wording.
Using "releases" for the list of tech team releases does
makes sense to be kept that way, for example:
releases/1.1.1.yaml

Issue: RELENG-2131
Change-Id: I9a9a548947cc1acbe3e61bb8fa6532a89fb17e16
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Merge "Fix typo and sphinx doc formatting"

Handle stack removal with the force option

Issue: RELENG-2058
Change-Id: I7e428c6b3a5dd0c21f10b368cb8e9584d5e77648
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Remove orphaned ports on the cloud env

Issue: RELENG-2059
Change-Id: I0ce6e5c832d5d9481ae1f13d85716da4cab774f8
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix typo and sphinx doc formatting

Change-Id: I6ad71ca93e2e258bb4a628f38acc12431d92447d
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix script indent to 4 spaces

Change the indent to 4 spaces which is consistant with
rest of scripts in the repo.

Add missing script anchor for debugging.

Change-Id: I543441162636b2931665b16ddc50836c11dfd7f8
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Add workaround for javadoc verify jobs

Nexus unpack plugin throws a "504 gateway timeout" for jobs archiving
large number of small files. Remove the workaround only we move away
from using Nexus as the log server.

Tested the workaround with javadoc-verify job.
https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/bgpcep-maven-javadoc-verify-sodium-openjdk8/189

Issue: IT-16635
Change-Id: Ic7b0e3a56800312e3bcb888b4d35f9ccfd2d5018
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Configure mvn-goals in maven-sonar.sh

Extend maven-sonar.sh to allow configuration of
maven goals for the build step. Set to default as
"clean install".
This change will not cause any issue for projects
already using this job.

Issue: RELENG-2184
Change-Id: Ic8fe16de24097ec9ef805a24de4cebaef934fb04
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Fix release-job.sh Nexus proxy var

Avoid the usage of project specific variables.
Do not use ODLNEXUSPROXY var, but instead use
a generalized variable.

Projects using lf-release-jobs need to make
sure they have the global variable NEXUSPROXY
added in Jenkins production and Jenkins sandbox
servers.
The value of this variable should be the URL to
the project's Nexus server.

Issue: RELENG-2131
Change-Id: Ia33c106c3c0ff86e57064deb74fb3863fcd90bdc
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Upgrade lftools to version v0.25.2

Change-Id: I211297034a7cd6629ce93fe5e1f31ef0ea5054f8
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Upgrade lftools to version v0.25.1

Change-Id: I98d8505aa8e293cb9c5ebe6193284e207e0930b1
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Fix releases-merge job

Add missing git-url variable in {project-name}-releases-merge-{stream}
job.

Change-Id: I8888b6fce6049de252e537c140c542c2945b3ff1
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Add {stream} to releases jobs

Add the {stream} variable to the verify and merge
releases jobs to make them:
{project-name}-releases-verfy-{stream} and
{project-name}-releases-merge-{stream}

Change-Id: I63dcd51ea5d6eaf2eb57442f72f7e2f339070a7d
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Allow version-properties-file parameter

Some ONAP components like DCAEGEN2 do not host a version.properties file
in the root of their repos. We need to be able to provide a location and/or
different name for the version.properties file for jobs using the
lf-maven-versions-plugin builder step.

Issue: RELENG-2136
Change-Id: Ie5ae50887276bf8a4f8da3f865cf35e6a2292494
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Update lftools version to **v0.25.0**

Change-Id: Ie72f9250e94c84b94b94f7e68f3fe8eb5dc4ef76
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Merge changes from topic "lf-release-jobs"

* changes:
  Add lf-release-jobs test and group
  Add fixes for lf-release-jobs

Add lf-release-jobs test and group

- Group {project-name}-releases-verify and {project-name}-releases-merge
  into {project-name}-gerrit-release-jobs.
- Add test jobs for lf-release-jobs.

Issue: RELENG-1657
Change-Id: I20b7348b299fda2333119326f9861f24d1645ec2
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Add fixes for lf-release-jobs

- Add missing scm block in gerrit-releases-merge job definition.
- Add missing submodule-disable for jobs using lf-infra-gerrit-scm.
- Add missing submodule-timeout variable in lf-releases-merge
- Remove submodule "Optional parameters" documentation for
  gerrit-releases-merge and gerrit-releases-verify.

Issue: RELENG-1657
Change-Id: I656fe6d27773022581cba9d8bb6c448ba97cf8e5
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>