Merge "Feat!: Convert packer templates to HCL2 format"

Feat!: Convert packer templates to HCL2 format

As of packer version 1.7.0 HCL2 is the preferred way to write Packer
templates. HCL2 preserves existing workflows while leveraging HCL2’s
advanced features like variable interpolation and configuration
composability.

Migrate packer templates from JSON to HCL2 format. JSON format
templates are deprecated and no longer works with packer
version > 1.9.x.

Packer version 1.9.1 will be minimum required version for packer jobs.
This version requires installing the cloud specific plugins through
packer config and needs to be initalized and downloaded with
`packer init` before running `packer build`.

Add support for host key algorithms to work with local ssh proxy
without which packer builds results in "failed to handshake" error.
Workaround is to pass additional params with "extra_arguments".

Support for '.json' templates will be removed from common-packer in
subsequent releases. All projects specific templates not available in this
repository are required to convert existing '.json' to '.pkr.hcl' format.

This change requires updating CI jobs with the additional steps.

Ref:
https://developer.hashicorp.com/packer/docs/templates/hcl_templates
https://github.com/hashicorp/packer-plugin-openstack/blob/main/README.md
https://github.com/hashicorp/packer-plugin-ansible/issues/140

Issue: RELENG-4764
Change-Id: Ie63d9551bd1bab224dc9335d45a21d5ee3e09550
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Feat: Modify Devstack templates to include Debian/Ubuntu

Issue: RELENG-4765
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
Change-Id: I3dbd5152b32a79673d92d00fa022793cf3caecfb

Fix: Remove delta rpm deps for CentOS Appstream 8

delta rpm is no longer available.

Issue: RELENG-4760
Change-Id: I172445e022fea08f20ef35f1802393ca8d01b722
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

CI: Remove packer-validation temporarily

The job needs to be re-designed for github
disable the job for voting until then.

Issue: RELENG-4761
Change-Id: Id9ba4e706f7802fb4cfd3770d977359e3052d0d4
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Feat: Add Openstack devstack template

Move the Openstack devstack templates to build VM's with devstack
installed and ready for testing. ORAN community has requested devstack
images to be available on the CI env.

The templates and provision files have been tested to build the latest
version of the devstack yoga on the CI.

ZZCI - CentOS Stream 8 - devstack-yoga - x86_64 - 20230612-132235.763

Issue: RELENG-4760
Change-Id: I60d37d769158f34b22b84111fd5229c616232c27
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix: prefix github.workspace

Issue: RELENG-4761
Change-Id: Iefb62656aa0d6ba4e5e4b69ae6b7c739e8184155
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix: pre-fix $HOME before var and templates

Issue: RELENG-4761
Change-Id: Iae022ef868236ccaf3d84bb76f87cecf941395cd
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix: Update packer validate script

Issue: RELENG-4761
Change-Id: Idefc0a43c2f47aa6834fe7809911add73289c3de
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

CI: Add GHA packer validation job

Issue: RELENG-4761
Change-Id: I48283360f553d4c4f1fd902e8868f6d7a86a4bd7
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix: Correct version label for GHA call

Issue: RELENG-4563
Change-Id: Ib677bb53ac47e27501c668d9bd744d61bee9613e
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Fix: Correct bad actions call

Issue: RELENG-4563
Change-Id: Ia368fed2b62d51bef3895b6f6cf9bd49042d6456
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Fix: Correct bad var def in release workflow

Issue: RELENG-4563
Change-Id: Ifcd528f511410ed1b3363890e58e37903de3b32f
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Merge "Chore: Update pre-commit hooks"

Merge "CI: Add GHA release workflow"

Merge "Refactor: Cleanup some pre-commit issues"

CI: Add GHA release workflow

Issue: RELENG-45633
Change-Id: Id0ce3d3888047a11c3f674cf2c9ba8b06a64c690
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Chore: Update pre-commit hooks

* github.com/pre-commit/pre-commit-hooks: v4.0.1 -> v4.4.0
* github.com/pre-commit/mirrors-prettier: v2.3.2 -> v3.0.0-alpha.6
* github.com/jorisroovers/gitlint: v0.15.1 -> v0.19.1
* github.com/jumanjihouse/pre-commit-hooks: 2.1.5 -> 3.0.0

Issue: RELENG-4563
Change-Id: Ie147b72b9e939ec57f4da56a9c2f220e2759fff2
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Refactor: Cleanup some pre-commit issues

* Cleanup some pre-commit issues
* Re-enable pre-commit as part of the default tox run
* Fix shellcheck error

Issue: RELENG-4563
Change-Id: I40b94b8dd2512118ebe0afcac556a42161cedbc8
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

CI: Docs tests require full repo history

Issue: RELENG-4563
Change-Id: Id3bcb21f1369c490e0dd35eccb35a488c27b2586
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

CI: Add GitHub Actions verify

Issue: RELENG-4563
Change-Id: Ie1d605c40e0aa3e7a9db7fe3bcfde059b50070ba
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Docs: Fix broken docs link

Correct a docs link that should be using an ignored example domain

Issue: RELENG-4563
Change-Id: Id8dbf72c6cc55a46d30248738b57813fad08663f
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Fix: Skip ansible provisioners version check

Packer provisioners invokes ansible version check which can be
skipped since the provisioner is invoking a custom script.

Issue-ID: RELENG-4473
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I661984bfc34857ff5ec42c63a695074f27e1492b

Feat!: Install ansible tools from PyPI

Install ansible through system packages causes dependencies
conflicts on CentOS 8 platform therefore update packer
templates to use ansible provisioner created
through venv.

Error:
Problem: package ansible-5.4.0-3.el8.noarch requires
(ansible-core >= 2.12.2 with ansible-core < 2.13), but none
of the providers can be installed

Issue-ID: RELENG-4473
Change-Id: I1d562386b4408c9674271e813dcd2aea6632e709
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix: Update Ubuntu installs on aarch64

Do not change package mirror for aarch64 systems as this breaks since
most mirrors do not carry the packages

Change-Id: I800e83295bba8b55e9376fc735cd9f7b21fddf32
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

CI: Require RELENG changes in commit messages

To make sure that JSD issues are not being referenced since that is not
public data, we will now start enforcing a requirement that commits have
a RELENG issue associated with them.

Issue: RELENG-4375
Change-Id: I37150383e0e986438fea01d549aa803f2f038100
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Feat: Upgrade git to v2.36 for CentOS7

- v2.24 packages are no longer available on the CentOS mirrors.
  Disable warning to use yum module.
- Fix install python script to check python/python3 to test, since
  the default python3 is not available on CentOS7 platforms.
- Print the default version of python installed.

Issue-ID: IT-24376
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: Id48ad72aba776ed4092a292c4db1ad6459d9ab64
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix: Import the correct gpg keys for sigul and EL8

Sigul 1.1.1 is signed by the Fedora infrastructure key
therefore import the Fedora infra key before installing
the updated version on Sigul for CentOS8.

Import the EL8 GPG keys without which would fail
while installing several dependencies.

Issue-ID: IT-24054
Change-Id: I440b263ebb5f424496f21aa15e58bf7b34279f6e
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix: Update doc refs to acumos

Acumos resources on the infra are decommissioned,
update the examples pointing to another project.

Change-Id: Ie3ea1892ed99d9ed7917c700fac35bf566a92c47
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Feat: Add support for CentOS Stream 9

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: If80413b418a1783efbc5f5c81d315abd5c64cb07

Chore: Update Ubuntu/Centos base images

Update RAW base images for Ubuntu 18.04, 20.04
and Centos 7

Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Change-Id: I2de5f6fb3aa354b85821e317fb2ceca0ac3b5eb0

CI: Disable pre-commit in CI

Packer has been having issues creating new images for a bit and
pre-commit is no longer working in CI because of something upstream
because of this.

Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Change-Id: I55cbfdb656294c980b1c499746404fc523202f1c

Fix: Install Sigul 1.1.1 for EL8 (CentOS Stream 8)

Sigul requires python3-nss that is only available through
dnf module repo (pki-{core,deps}). These additional repo
need to be enabled for the Sigul to pull in the required
dependencies.

Note: `dnf module install|enable` is available through
Ansible playbooks, so use the command module instead.

Issue-ID: LF-JIRA IT-23826
Change-Id: Iff194240fc417ae92a2ea6caf0511c85cc973b41
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Chore: Update to python38

The provisioning script fails with errors while
trying to install python36 on CentOS8 image build.

python 3.6 is EOL, bump the install script to use python 3.8.

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I0431ee938c9da1c254e9ccc80c0e7d760bbde0ff

Fix: Use lowercase for CentOS Stream var file

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I32edf055ce807fbcfc2b176fdfbd943256efa782

Feat: Add support for CentOS Streams 8

Issue-ID: RELENG-4141
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I172aa7399e5f235082f058c7ab4690d83c5ad381

Chore: Update base images for Ubuntu

Update base images for Ubuntu 18.04 and 20.04
ARM and x86

Issue: RELENG-4010
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Change-Id: I243b0547173afb79f38755c74dc4891a71b551ea

Chore: Update Ubuntu 18.04

Update base image for Ubuntu 18.04

Issue: RELENG-3989
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Change-Id: I1821b6678745c89842936ced72e8cda06abf939b

Chore: Upgrade pre-commit hooks

* github.com/pre-commit/pre-commit-hooks: v3.4.0 -> v4.0.1
* github.com/pre-commit/mirrors-prettier: v2.2.1 -> v2.3.2

Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Change-Id: I5499abc30a514568d7a4fe30f679d10c4fff5a22

Fix: Add missing Release Notes for latest packer

Add Release Notes for packer requirements changed
recently.

Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Change-Id: I459c7da09c3a5262e4093d98c763a21dd73df0b3

Fix: format of requirements.yaml

Signed-off-by: quentinDERORY <quentin.derory@ecole.ensicaen.fr>
Change-Id: Ibaef85987792566938a0ea7ef397148701c371ca

Chore: Add new galaxy requirement for magma project

Signed-off-by: quentinDERORY <quentin.derory@ecole.ensicaen.fr>
Change-Id: I6a884a6d3c831222a095d1f75f958f1eed18c815

Fix: Use Vexx provided base images

Use base images provided by Vexx instead of
LF's ones.

Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Change-Id: If2ecdf622235ae82211bd0051314713775676c23

Fix: Enable powertools repo for CentOS 8.* vers

The CR I43b943ddfc38faca does not work as expected since
ansible_facts does not match/return the minor versions of
the Repoid correctly.

For CentOS 8.2.2004 and earlier versions uses repoid as
'PowerTools' while CentOS 8.3.2011 and later versions uses repoid as
'powertools'. To handle this, check the repo file name under
/etc/yum.repos.d/ and enable the correct repository.

Ref: https://wiki.centos.org/Manuals/ReleaseNotes/CentOS8.2011\
Issue: RELENG-3710
Change-Id: Ib6a8d78664bbb5f20d2889fae3ae3b4238007141
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix: AMI product codes need to be defined

While trying to upgrade the internal Jenkins to latest global-jjb and
common-packer it's been found that all of our configurations for AWS
systems are missing vital filters.

The Ubuntu product codes were found by doing the following:

aws ec2 describe-images --region us-west-2 \
  --owners aws-marketplace --filters \
  "Name=architecture,Values=arm64" \
  "Name=name,Values=*ubuntu*20.04*" \
  "Name=manifest-location,Values=aws-marketplace/ubuntu/*"

This is per documentation found at
https://ubuntu.com/server/docs/cloud-images/amazon-ec2

Issue: RELENG-3757
Change-Id: I9391f6bec59318e00bc1b097c7a27181defeccff
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

CI: Configure gitlint for Conventional Commits

Turn on Conventional Commit message subject validation. This will affect
CI specifically, but developers can avoid having CI fail by assuring
that they have installed pre-commit and that they have also run

pre-commit install --hook-type commit-msg

The above is needed because pre-commit does not install commit-msg hooks
by default

Change-Id: I99779c6188ab2a4e57022a4ac552cbc3749accc2
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

CI: Update pre-commit and make it work properly in CI

Change-Id: Idf2dbf580ca14af8a3c868a385658b4d51c4de9e
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Feat: Add support for Docker builder on Windows

The original change e24c07369afd514abdf3efb0f596f772261412ed
missed updating Windows var files, while the builder templates were
updated. This breaks the packer verify jobs.

Error:
    required variable not set: docker_source_image'

Change-Id: Iac258a0ff132e12e00a49d9d02ce0f1806bef016
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Feat: Add support for Docker builder on arm64

The original change e24c07369afd514abdf3efb0f596f772261412ed
missed updating arm64 var files and Ubuntu 20:04 var file,
while the builder template were updated. This breaks the
packer verify jobs.

Error:
* required variable not set: docker_source_image'

Issue: RELENG-3717
Change-Id: I1f3acf1479bf7a4ab271f747da5261ee2619e566
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix: Change powertools repoid to lowercase

The repoids are renamed with CentOS 8.3 update breaks the packer
builds. Now the correct repoid to use is 'powertools' instead
of 'PowerTools'

Error: No matching repo to modify: PowerTools.

Ref:
https: //wiki.centos.org/Manuals/ReleaseNotes/CentOS8.2011#Yum_repo_file_and_repoid_changes
Issue: RELENG-3710
Change-Id: I43b943ddfc38facaa8c02f2d6ee98254e7ee3241
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Add docker-aws template

We now have at least one project on AWS that needs a docker template.

Issue: IT-21917
Change-Id: Ia08a1a32eb2ffaab46b1f01468018de688423852
Signed-off-by: Eric Ball <eball@linuxfoundation.org>

Merge "Use official CentOS & Ubuntu images via prodId"

Use official CentOS & Ubuntu images via prodId

The previous filter method could result in getting an unexpected image
even one that's entirely different than what is intended. This patch
uses a product-code search of the marketplace for the official upstream
supported images rather than the custom ones provided by Amazon.

This patch is based on Zack William's suggestion on the lf-releng
mailinglist.

Reference:
https://lists.linuxfoundation.org/pipermail/lf-releng/2020-February/000135.html

Change-Id: Ia6208bd7a61036eb210d07533e3ceedbbc787678
Co-authored-by: Zack Williams <zdw@opennetworking.org>
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Add support for a Docker builder

Adding a Docker builder will allow us to more easily test build images
locally in a container before pushing a patch to production to build
the VMs themselves. While not guarenteed to be exactly the same it's
a close enough approximation that many issues can be caught before
patches are pushed.

Additionally this allows projects to also use the same packer templates
to build container based builder nodes if there's any projects using
Docker for their Jenkins jobs.

Issue: RELENG-1052
Change-Id: If89801cea16046900e7e880265ad859a96595fa1
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Merge "Update CentOS8 image"

Fixing netselect in install-python

Actually use the result from netselect

Issue-ID: CIMAN-30

Signed-off-by: Bengt Thuree <bthuree@linuxfoundation.org>
Change-Id: I31b5858dc4b348f383f3b801b17c1aa8547296bd

Update CentOS8 image

Change-Id: If34cb35b7b54b7015e7c20a53c9ace9c10db5500
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Merge "Migrate jobs from lf-standard-1 flavor to v3"

Update shellcheck pre-commit hook to 2.1.5

With 2.1.5 release the workaround added in
d7d264e733e5 is no longer required.

Change-Id: I7e890d03844a2fb47159ad471f166310290fbf9f
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Migrate jobs from lf-standard-1 flavor to v3

v3 flavors guarantees jobs spin on newer hardware that
are faster and cost-efficient than the v2 flavors.

Issue: RELENG-3329
Change-Id: I97f8d540f02fdccb3115bc624b167eb12464833b
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Add workaround to for shellcheck failure

The shellcheck hook breaks with the latest version of pre-commit (2.1.1)

[ERROR] The hook `shellcheck` specifies `additional_dependencies`
but is using language `script` which does not install an environment.

Ref:
https://github.com/jumanjihouse/pre-commit-hooks/pull/81

Change-Id: I19d8b26a7589d0bde7f1d3c6f768b738289ab937
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Revert "Set packer builder type with env variable"

This reverts commit cc035619ac1673a5b5ea2f6bfb843eac75ea4a9d.

Based on the input provided on the Gihub packer issue
hard-coded for our parser to be able to decode the rest of the config
properly."

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: If63b83eae7baa8ab6b30d8b9b187aa219ec2ba44

Revert "Set packer builder type with env variable"

This reverts commit 8041971ef211709579f919bdeb9a77fef0a29433.

Based on the input provided on the Gihub packer issue
hard-coded for our parser to be able to decode the rest of the config
properly."

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I52ef1448fc53b2b9777786994683fbd705a1f8ba

Set packer builder type with env variable

Using the -only CLI option for packer build does not work as
expected. The #CR 90dd675df482a8 (global-jjb) submitted with
common-packer v0.7.0 fails to build packer jobs because of a
bug in the packer build CLI.

The `-only` option packer build CLI does not set the cloud
provider name/type as per the documentation. The alternative
is to use an environment variable that is passed through the
packer job and can be reference in the packer templates.

The CR cc035619ac16 missed including the changes to the other
templates.

Issue: https://github.com/hashicorp/packer/issues/10495
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I14976aa77312a3d887d30b7d6e2cc32ab8073b72

Set packer builder type with env variable

Using the -only CLI option for packer build does not work as
expected. The #CR 90dd675df482a8 (global-jjb) submitted with
common-packer v0.7.0 fails to build packer jobs because of a
bug in the packer build CLI.

The `-only` option packer build CLI does not set the cloud
provider name/type as per the documentation. The alternative
is to use an environment variable that is passed through the
packer job and can be reference in the packer templates.

Issue: https://github.com/hashicorp/packer/issues/10495
Change-Id: I1c1e2e7c5545df5a2a374a02714634a0f4086378
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Remove openstack AZ from templates

The availability zone started causing issues with packer builds. Per
Vexxhost help, there is only one AZ, and removing this line
alleviates the issue.

Issue: RELENG-3344
Change-Id: Icf60fe527ae328d7883ef38c3efba9972d2f2669
Signed-off-by: Eric Ball <eball@linuxfoundation.org>

Update prettier URL for pre-commit

Issue: RELENG-3344
Change-Id: I07daf63bcb03252367b11a64f44c938bf807eea6
Signed-off-by: Eric Ball <eball@linuxfoundation.org>

Merge "Workflow for updating images."

Workflow for updating images.

documenation on:
"Update Packer Base Image"
and
"Update Packer Images to reflect changes
in LF ansible galaxy roles"

ISSUE: RELENG-2363
Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
Change-Id: Ia2bac9c336772742bf58058114b1668498cfcbd3

Add Ubuntu 20.04 arm64 image

Issue: JSD IT-20435
Change-Id: I5f21934ec15754892d3ebea826965167edb84601
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Add Ubuntu 20.04 amd64 image

Issue: JSD IT-20435
Change-Id: Iec986b683fe168c417c40c0815d743d28c288dd6
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Merge "Add support for Ubuntu 20.04 and newer"

Ensure sudo is installed as Ansible requirement

Ansible requires sudo to be available and Docker images do not
typically come with sudo pre-installed so add code to ensure it
get's pulled in.

Issue: RELENG-1052
Change-Id: I8e67f7048f2199f208c7596cb7b7c6182e61ed51
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Rename vexxhost to openstack for builder names

Considering the AWS builders are named AWS after the service let's
rename the vexxhost ones to openstack. As far as I am aware we are
not supporting multiple providers with the same backend at the same
time so this will make things consistent.

When we later add docker support it will just be called "docker" as
well.

Issue: RELENG-1052
Change-Id: I8f46d544961e508cdeee28d4e761c2feae5e744e
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Add support for Ubuntu 20.04 and newer

Ubuntu 20.04 no longer has python-* packages and instead the packages
are now more explicitly either python2-* or python3-* with packages
named python-is-python[23] to set the default. This patch when run
on Ubuntu systems will check if python-is-python3 is available and
installs that as the system python version, otherwise installs
python-minimal.

Also adjust the comments since they are no longer accurate or in the
right places.

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I830e0250ddbee395fdeddd78fcc7824f7855d75d

Update Ubuntu 18.04 base image

Change-Id: I4b40ff1c84cfa2f64235b3a8132e6d43baea1f3a
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Update Ubuntu base image to 2020-07-28 snapshot

base image was uploaded in qcow2 format.
this casued timeout in packer builds.
new image is in raw format.

Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
Change-Id: I0151e6b8677625e4477d93faa67cb1abdf84515c

Add release notes for sigul client on CentOS 7

Issue: RELENG-3077
Change-Id: I3314b0770a0f0280ee162bbb646f95312cff6196
Signed-off-by: Eric Ball <eball@linuxfoundation.org>

Add install of Sigul client on CentOS 7

Our current signing scripts download and install Sigul only when
executing the signing scripts. However, the servers hosting this
package are not reliable, and we should see significant performance
improvements by having the package pre-loaded on CentOS 7 builders
(the only builders capable of using Sigul).

Issue: RELENG-3077
Change-Id: I35ac34a3619f4018331f280745f4ff3d5c864fa9
Signed-off-by: Eric Ball <eball@linuxfoundation.org>

Update the CentOS 7 base image to the latest

https://cloud.centos.org/centos/7/images/CentOS-7-x86_64-GenericCloud-2003.raw.tar.gz

Issue: IT-19958
Change-Id: Ib6f84fc36d6644c286540abd11c8446bea78497f
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix provisioner to install Git 2 from IUS

While patch Ibace4cdf89d0615a2e5117f9ea3ca50730d5c93d fixed the setup
for the IUS repo. It failed to ensure that Git 2 is installed from the
IUS repo.

In the refactored IUS repo git2u no longer exists and instead the
latest Git package appears to be git224 so let's update to that
version.

Also class cast ansible_distribution_major_version|int as this variable
normally returns a type AnsibleUnsafeText which cannot be compared to
an int type.

Change-Id: I1cd815fb0440be996ba66c3a48eab9d6da02f4bb
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Merge "Run docs and docs-linkcheck in verify"

Merge "Add .editorconfig file"

Merge "Print git-diff when pre-commit fails"

Run docs and docs-linkcheck in verify

Not sure why we weren't running docs build tests as part of the
common-packer verify build but this patch updates tox to enable
those build tests.

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I7d28bdf8ace6946bcf1b6a2d08bc1408875fce96

Add .editorconfig file

EditorConfig is a universal editor configuration file supported by many
IDEs and Editors (although some might require installing a plugin) to
share consistent editor configuration with developers using different
editors.

Ref: https://editorconfig.org/
Change-Id: I59a4a57298e295dcfe7d21591a8c0fb501b0cef6
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Print git-diff when pre-commit fails

When pre-commit fails and automatically fixes issues for us in Jenkins
we are not able to see what pre-commit automatically fixed. Adding
--show-diff-on-failure makes pre-commit perform a git-diff immediately
after failing to ensure more useful output is printed to inform the
contributor what changes are needed to pass the check.

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: Ic2ad49fd6222bee0341c4826e6ccc463d05fda5f

Update pre-commit hooks 2020-06

It's been awhile since we last updated the pre-commit hooks so let's
catch up with the world.

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: Ibf5e945a2bb6324c73ea5b2d7a683bc0f926384b

Fix PowerTools enablement and IUS install

* Use correct syntax for verifying the major version(s) we
  should be setting IUS up on
* Fix the fact we're checking to know if should be enabling
  the PowerTools repo

Change-Id: I3340d5aae147a2c5881d973442fba4e9543d8c1e
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Fix version comparison for PowerTools installation

Apparently ansible_distribution_major_version returns a string and
cannot therefore properly be tested in an integer based test. Use the
version() function instead.

https://docs.ansible.com/ansible/latest/user_guide/playbooks_tests.html#version-comparison

Change-Id: I7abb42f94b1543aed5fe3ca548184ac1082612d7
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Support CentOS 8 builds

Changes needed to run the packer against CentOS 8 systems

Issue: RELENG-2823
Change-Id: I7748d98150630bc5327d407eab5421a2ec21e7bf
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Add Centos 8 base image

Issue-ID: RELENG-2823
Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: I6c00ef45e269028f60a06f7f4aa9c38729ad952a

Update ARM base images

Update the latest (tested) baseimages for ARM
Ubuntu 16.40 and Ubuntu 18.04

Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Change-Id: Ide6115ef7f9d3e42935011aaf37872adc759e589

Install netselect depending on the Ubuntu arch

Change-Id: Ie93b7b5d510ff1e067db4fcfc1020f9ae93dadcf
Signed-off-by: Bengt Thuree <bthuree@linuxfoundation.org>
Signed-off-by: Eric Ball <eball@linuxfoundation.org>
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Allow the jenkins user to sudo as any user

Previously the Jenkins user could only sudo and run commands as root.
This change allows the Jenkins user to `sudo -u another_user` without
providing a password. This is useful for test suites that need to
perform commands as different user accounts and not just root.

Change-Id: Ib7864e8b9370ae7f1a2a8bec82cf609e7dcccead
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Minor Cleanup

Change-Id: Ia826901dbbc1a3fd6f5df4af22418015b9dbc78c
Signed-off-by: Tim Johnson <tijohnson@linuxfoundation.org>

Do not fail the build when a mirror is not found

Forgot to include this check in the change 4c9db8e41b3b546a52.
netselect checks for the mirrors from the list and when one
or more mirrors are not available returns the below error
causing the build to fail.

error:
netselect: unknown host gpl.savoirfairelinux.net/pub/mirrors/ubuntu/

Issue: RELENG-2642
Change-Id: I4351a40be996092febe4efe956b18a9a575c994e
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Merge "Use netselect to choose a package mirror"

Merge "Revert "Use apt-get to install python-minimal""

Add GitLint which replaces GitCommitBear

The GitCommitBear was removed via
I8d782822ca87add9108a044fd6e19b1c23686717 this replaces it with
GitLint which does similar linting for git commit messages.

Issue: RELENG-2642
Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I6e47db45a6c5c519ee795adf15c4243fb0bfb6dd