releng/global-jjb.git
5 years agoFix script indent to 4 spaces 11/16111/2
Anil Belur [Sun, 7 Jul 2019 00:31:16 +0000 (10:31 +1000)]
Fix script indent to 4 spaces

Change the indent to 4 spaces which is consistant with
rest of scripts in the repo.

Add missing script anchor for debugging.

Change-Id: I543441162636b2931665b16ddc50836c11dfd7f8
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
5 years agoConfigure mvn-goals in maven-sonar.sh 04/16104/1
Jessica Wagantall [Fri, 5 Jul 2019 19:26:17 +0000 (12:26 -0700)]
Configure mvn-goals in maven-sonar.sh

Extend maven-sonar.sh to allow configuration of
maven goals for the build step. Set to default as
"clean install".
This change will not cause any issue for projects
already using this job.

Issue: RELENG-2184
Change-Id: Ic8fe16de24097ec9ef805a24de4cebaef934fb04
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoFix release-job.sh Nexus proxy var 73/16073/1
Jessica Wagantall [Thu, 4 Jul 2019 02:09:20 +0000 (19:09 -0700)]
Fix release-job.sh Nexus proxy var

Avoid the usage of project specific variables.
Do not use ODLNEXUSPROXY var, but instead use
a generalized variable.

Projects using lf-release-jobs need to make
sure they have the global variable NEXUSPROXY
added in Jenkins production and Jenkins sandbox
servers.
The value of this variable should be the URL to
the project's Nexus server.

Issue: RELENG-2131
Change-Id: Ia33c106c3c0ff86e57064deb74fb3863fcd90bdc
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoUpgrade lftools to version v0.25.2 56/16056/1 v0.39.1
Anil Belur [Tue, 2 Jul 2019 21:33:55 +0000 (07:33 +1000)]
Upgrade lftools to version v0.25.2

Change-Id: I211297034a7cd6629ce93fe5e1f31ef0ea5054f8
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
5 years agoUpgrade lftools to version v0.25.1 07/16007/1 v0.39.0
Andrew Grimberg [Wed, 26 Jun 2019 22:32:09 +0000 (15:32 -0700)]
Upgrade lftools to version v0.25.1

Change-Id: I98d8505aa8e293cb9c5ebe6193284e207e0930b1
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
5 years agoFix releases-merge job 70/15970/1
Jessica Wagantall [Fri, 21 Jun 2019 18:31:34 +0000 (11:31 -0700)]
Fix releases-merge job

Add missing git-url variable in {project-name}-releases-merge-{stream}
job.

Change-Id: I8888b6fce6049de252e537c140c542c2945b3ff1
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoAdd {stream} to releases jobs 69/15969/1
Jessica Wagantall [Fri, 21 Jun 2019 18:11:54 +0000 (11:11 -0700)]
Add {stream} to releases jobs

Add the {stream} variable to the verify and merge
releases jobs to make them:
{project-name}-releases-verfy-{stream} and
{project-name}-releases-merge-{stream}

Change-Id: I63dcd51ea5d6eaf2eb57442f72f7e2f339070a7d
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoAllow version-properties-file parameter 05/15905/3
Jessica Wagantall [Fri, 14 Jun 2019 23:07:47 +0000 (16:07 -0700)]
Allow version-properties-file parameter

Some ONAP components like DCAEGEN2 do not host a version.properties file
in the root of their repos. We need to be able to provide a location and/or
different name for the version.properties file for jobs using the
lf-maven-versions-plugin builder step.

Issue: RELENG-2136
Change-Id: Ie5ae50887276bf8a4f8da3f865cf35e6a2292494
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoUpdate lftools version to **v0.25.0** 91/15891/1 v0.38.4
Anil Belur [Thu, 13 Jun 2019 21:52:10 +0000 (07:52 +1000)]
Update lftools version to **v0.25.0**

Change-Id: Ie72f9250e94c84b94b94f7e68f3fe8eb5dc4ef76
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
5 years agoMerge changes from topic "lf-release-jobs"
Andrew Grimberg [Thu, 13 Jun 2019 21:18:24 +0000 (21:18 +0000)]
Merge changes from topic "lf-release-jobs"

* changes:
  Add lf-release-jobs test and group
  Add fixes for lf-release-jobs

5 years agoAdd lf-release-jobs test and group 76/15876/5
Jessica Wagantall [Wed, 12 Jun 2019 23:55:41 +0000 (16:55 -0700)]
Add lf-release-jobs test and group

- Group {project-name}-releases-verify and {project-name}-releases-merge
  into {project-name}-gerrit-release-jobs.
- Add test jobs for lf-release-jobs.

Issue: RELENG-1657
Change-Id: I20b7348b299fda2333119326f9861f24d1645ec2
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoAdd fixes for lf-release-jobs 75/15875/3
Jessica Wagantall [Wed, 12 Jun 2019 23:53:02 +0000 (16:53 -0700)]
Add fixes for lf-release-jobs

- Add missing scm block in gerrit-releases-merge job definition.
- Add missing submodule-disable for jobs using lf-infra-gerrit-scm.
- Add missing submodule-timeout variable in lf-releases-merge
- Remove submodule "Optional parameters" documentation for
  gerrit-releases-merge and gerrit-releases-verify.

Issue: RELENG-1657
Change-Id: I656fe6d27773022581cba9d8bb6c448ba97cf8e5
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoUse login shell in docker-get-container-tag.sh 77/15877/2
Lott, Christopher (cl778h) [Thu, 13 Jun 2019 02:01:56 +0000 (22:01 -0400)]
Use login shell in docker-get-container-tag.sh

Add -l to /bin/bash shebang line at top of docker-get-container-tag.sh
to make it a login shell, which automatically includes
/home/jenkins/.local/bin on the path, because that is where pip
installs the yq command.

Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: I6b715b8d3757414344fe154d9b8a0d44feb1daaa

5 years agoAdd missing $ in shell command 72/15872/1
Lott, Christopher (cl778h) [Wed, 12 Jun 2019 18:00:04 +0000 (14:00 -0400)]
Add missing $ in shell command

Add missing $ to variable tag_file so the yq query can pull
the tag from the container-tag.yaml file.

Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: If1d99fca46f2a0cc6ea8328d7ed1b1495c7af116

5 years agoMerge "typo and add link for jenkins Managed Files"
Andrew Grimberg [Mon, 10 Jun 2019 19:31:59 +0000 (19:31 +0000)]
Merge "typo and add link for jenkins Managed Files"

5 years agotypo and add link for jenkins Managed Files 59/15859/3
Daniel Pono Takamori [Mon, 10 Jun 2019 18:58:59 +0000 (11:58 -0700)]
typo and add link for jenkins Managed Files

Change-Id: Ifc86f759b6fb732d76a93f79d1caca2bfbafb9c3
Signed-off-by: Daniel Takamori <dtakamori@contractor.linuxfoundation.org>
5 years agoRefactor templates and scripts for container tag 55/15855/8
Lott, Christopher (cl778h) [Mon, 10 Jun 2019 14:56:30 +0000 (10:56 -0400)]
Refactor templates and scripts for container tag

Change parameter names used to specify container tag method,
with a new default to use the fixed string 'latest' as a tag.
Merge two shell scripts into one instead of using Jenkins
conditional steps.
Extend to accept a custom directory for the container-tag.yaml
if the yaml-file method is used to set the docker tag information;
this is an optional variable which is set to empty by default,
and falls back to DOCKER_ROOT.

Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: I19a8809650fa29706acaf0f06f4b666bef0067d7

5 years agoUpdate lftools version v0.24.0 36/15836/1 v0.38.3
Anil Belur [Fri, 7 Jun 2019 02:13:59 +0000 (12:13 +1000)]
Update lftools version v0.24.0

Change-Id: Ieee1cb98c5ed7e191bd208213aa8663de6cb2ed4
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
5 years agoAdd missing closing bracket 24/15824/3
Thanh Ha [Thu, 6 Jun 2019 23:45:23 +0000 (09:45 +1000)]
Add missing closing bracket

Patch I45070e0b364136b28e4130aed3972603e8c2e3c1 caused a regression
which broke the image protection code due to missing square bracket.

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I6ceed9f7243425e43748824036e2ebd431906eec
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
5 years agoAdd numpy to tox.ini 29/15829/1
Anil Belur [Thu, 6 Jun 2019 21:31:18 +0000 (07:31 +1000)]
Add numpy to tox.ini

Change-Id: I358a77f71e86f0c86966fbc6e1eb7389e3268cdd
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
5 years agoAdd yamllint to info-file-validate.sh 17/15817/2
Jessica Wagantall [Tue, 4 Jun 2019 22:47:29 +0000 (15:47 -0700)]
Add yamllint to info-file-validate.sh

Run yamllint as part of info-file-validate.sh
to catch lint errors.

Change-Id: I4bf3e85b69481f7e5cdca989af1e7ec034966538
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoAdd trigger-on-cron to docker merge job 02/15802/1
Lott, Christopher (cl778h) [Mon, 3 Jun 2019 14:12:12 +0000 (10:12 -0400)]
Add trigger-on-cron to docker merge job

Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: I6e1d46d3b4e10a5e694201aeb493a4ef152ee954

5 years agoAdd missing file-based triggers to docker templates 99/15799/4 v0.38.2
Lott, Christopher (cl778h) [Sat, 1 Jun 2019 11:25:27 +0000 (07:25 -0400)]
Add missing file-based triggers to docker templates

Includes gerrit_trigger_file_paths and github_included_regions.
In documention: add github_included_regions parameter and
correct gerrit_verify_triggers to gerrit_merge_triggers.

Change-Id: If1dd342d9fe8591028cd1fabcb7c830e41df2fe5
Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
5 years agoUpdate docker scripts 86/15786/12 v0.38.1
Jessica Wagantall [Thu, 30 May 2019 00:43:45 +0000 (17:43 -0700)]
Update docker scripts

- docker-build: Allow DOCKER_ARGS to be empty. This is not
a required parameter, it can be empty.
- docker-get-git-describe: Remove container reference. The
CONTAINER_PUSH_REGISTRY already gets added in the docker-push
script. No need to add it again. Only process the tag variable.
- docker-get-yaml-tag: Rename image_name to image_build_tag
to match docker-get-git-describe. Add missing "DOCKER_NAME" in
the DOCKER_IMAGE. Only process the tag variable.
- docker-push: Update the correct image name and tag in the push
command.

Change-Id: Ic3aad7ae0f87b589ce5d57f6848f7e8e75f9b71e
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoUpdate lf-docker-jobs to enforce macro vars 90/15790/3
Jessica Wagantall [Thu, 30 May 2019 00:43:45 +0000 (17:43 -0700)]
Update lf-docker-jobs to enforce macro vars

Enforce the variables from "lf-docker-get-container-tag",
"lf-docker-build" and "lf-docker-push" to be carried over
when calling the macros. This avoids the issue of loosing
the value of the variables.
Update the test file to reflect the example better.

Change-Id: I5087b6fbd064d145fab4be8dad72ff196fdfa213
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoMove yq install to python-tools-install 89/15789/2
Jessica Wagantall [Thu, 30 May 2019 17:55:50 +0000 (10:55 -0700)]
Move yq install to python-tools-install

This will allow future scripts to use yq package.

Change-Id: Ic855363698cfeb28c5f3428dd381f42c3ea5b1a3
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoInstall yq in docker-get-yaml-tag.sh 87/15787/2
Jessica Wagantall [Thu, 30 May 2019 05:55:02 +0000 (22:55 -0700)]
Install yq in docker-get-yaml-tag.sh

Install yq which will be needed to read container-tag.yaml

Change-Id: I0f284675fe45cd2c408a4e1d6933673b744f2735
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoMerge "Add Docker Verify and Merge jobs" v0.38.0
Jessica Wagantall [Wed, 29 May 2019 21:10:40 +0000 (21:10 +0000)]
Merge "Add Docker Verify and Merge jobs"

5 years agoAdd Docker Verify and Merge jobs 61/14561/24
Jessica Wagantall [Wed, 13 Feb 2019 18:13:19 +0000 (10:13 -0800)]
Add Docker Verify and Merge jobs

Add {project-name}-docker-verify-{stream} and
{project-name}-docker-merge-{stream} jobs.

Issue: RELENG-908
Change-Id: I009fea61fd4c13daebac0d14f5dc00e1a90011e7
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoPass multiple pattern args in logs-deploy.sh 69/15769/2
Tim Johnson [Mon, 27 May 2019 22:57:04 +0000 (15:57 -0700)]
Pass multiple pattern args in logs-deploy.sh

Pass multiple args from ARCHIVE_ARTIFACTS as separate '-p' arguments to
'lftools deploy'

RELENG-2039
Change-Id: I35475a20e499731aac454b66fbb347c7d861f609
Signed-off-by: Tim Johnson <tijohnson@linuxfoundation.org>
5 years agoRevert "Pass multiple pattern args in logs-deploy.sh" 61/15761/1
Anil Belur [Mon, 27 May 2019 01:21:12 +0000 (11:21 +1000)]
Revert "Pass multiple pattern args in logs-deploy.sh"

This reverts commit 2dcdf635f5b1d7feffa3af9fe4f15368a0f1ebe7.

The change does not handle the case when the archive artifacts
are empty.

Change-Id: I0601254373777078f86834bf52bedb37fda6cb65
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
5 years agoPass multiple pattern args in logs-deploy.sh 02/15702/9
Tim Johnson [Fri, 17 May 2019 02:16:10 +0000 (19:16 -0700)]
Pass multiple pattern args in logs-deploy.sh

Pass multiple args from ARCHIVE_ARTIFACTS as separate '-p' arguments to
'lftools deploy'

RELENG-2039
Change-Id: I91fd4ddba273034f1568523c3694ac2605368663
Signed-off-by: Tim Johnson <tijohnson@linuxfoundation.org>
5 years agoAutomate Artifact release 29/14229/60
Aric Gardner [Wed, 16 Jan 2019 21:45:30 +0000 (16:45 -0500)]
Automate Artifact release

This will be adapted to work for ONAP/Other projects
once we are okay with this.

projects that want self-serve releases will create a
tagname.yaml file in the releases/ directory of their git repo.

Here is the change I have been testing in the sandbox
https://git.opendaylight.org/gerrit/#/c/80613/

example of a releases file:
$ cat releases/1.0.0.yaml
---
distribution_type: 'maven'
version: '1.0.0'
project: 'zzz-test-release'
log_dir: 'zzz-test-release-maven-stage-master/17/'
maven_central_url: 'oss.sonatype.org'

Issue: RELENG-1657

Change-Id: I02dc935a84425d194cdd8eaabe5b43c5920ce319
Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
5 years agoMerge "Fix info-vote job"
Andrew Grimberg [Fri, 24 May 2019 17:24:29 +0000 (17:24 +0000)]
Merge "Fix info-vote job"

5 years agoUpdate gerrit comment trigger keywords with regex 38/15738/3
Anil Belur [Thu, 23 May 2019 01:11:55 +0000 (11:11 +1000)]
Update gerrit comment trigger keywords with regex

Update gerrit comment trigger to use standard regex
and avoid triggering jobs, when these keywords are used as
gerrit comments between users.

Change-Id: Iac67e9508fd600650c4ed351094cfdaf2e212835
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
5 years agoPin requests to 2.21.0 26/15726/3
Anil Belur [Tue, 21 May 2019 08:27:41 +0000 (18:27 +1000)]
Pin requests to 2.21.0

request-2.22.0 does not work with python-3.4.9, so pin requests
to 2.21.0.

Change-Id: I8f79fdd2ba2100eb41f0d5e9a23862950e07e7bc
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
5 years agoFix info-vote job 75/15675/8
Aric Gardner [Tue, 14 May 2019 20:16:07 +0000 (16:16 -0400)]
Fix info-vote job

When majority voting checks out:
info-vote job must verify, sleep for a second,
and then submit based on GERRIT_PATCHSET_REVISION

change compare type from REGEX to ANT for file trigger

Replace comment-added with comment-added-event
Also remove the depreciated CDRV and only have Code-Review

Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
Change-Id: Ie9477b0e0b3cfc193469fe55bc59eecae72ef756

5 years agoMerge "Handle unbound arrays correctly"
Anil Belur [Tue, 14 May 2019 22:22:06 +0000 (22:22 +0000)]
Merge "Handle unbound arrays correctly"

5 years agoHandle unbound arrays correctly 66/15666/4
Anil Belur [Tue, 14 May 2019 13:14:05 +0000 (23:14 +1000)]
Handle unbound arrays correctly

The change cfe54b794b3814f288009b796e82668ba8846ca1 missed
handling unbound arrays with `set -u`.

Issue: RELENG-2013
Change-Id: Ic37ce0404f13bff04aa4122c9b1c91add78e2145
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
5 years agoMerge "Fix builder steps in lf-maven-docker-stage"
Daniel Pono Takamori [Tue, 14 May 2019 20:50:21 +0000 (20:50 +0000)]
Merge "Fix builder steps in lf-maven-docker-stage"

5 years agoChange project comapre type to ANT 73/15673/1
Aric Gardner [Tue, 14 May 2019 19:17:17 +0000 (15:17 -0400)]
Change project comapre type to ANT

REG_EXP was the wrong compare type

Saw this in the logs:

Exception caught for project info-vote and pattern *, message: Dangling
meta character '*' near index 0

Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
Change-Id: I69bdda475ad85ee7aefafc559f25bdaf22a84ec3

5 years agoFix builder steps in lf-maven-docker-stage 72/15672/2
Jessica Wagantall [Tue, 14 May 2019 18:59:14 +0000 (11:59 -0700)]
Fix builder steps in lf-maven-docker-stage

lf-maven-versions-plugin builder step needs to run before
maven-patch-release.sh as this second script contains a
condition to confirm if the maven vesions plugin was selected
as a way to remove the 'SNAPSHOT' pattern from the pom.xml
files.
lf-maven-docker-stage was based on lf-maven-stage and it
seems that these particular builder steps were switched in
place accidentally.

Change-Id: I30ac4af2a7566cb2c1072412a738f38d4f3318fb
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoMerge "Handle multiple search extension passed by JJB"
Anil Belur [Mon, 13 May 2019 23:38:16 +0000 (23:38 +0000)]
Merge "Handle multiple search extension passed by JJB"

5 years agoMerge "Update status-context to append java-version"
Andrew Grimberg [Mon, 13 May 2019 21:15:06 +0000 (21:15 +0000)]
Merge "Update status-context to append java-version"

5 years agoUpdate status-context to append java-version 99/15599/8
Suresh Channamallu [Fri, 10 May 2019 18:15:45 +0000 (14:15 -0400)]
Update status-context to append java-version

Multiple jobs created using same job-template updating same github check status
due to hard coded status-context to Maven Verify.
Now appending status-context with maven-version and java-version to make it unique.

Issue: RELENG-2027
Signed-off-by: Suresh Channamallu <schannamallu@linuxfoundation.org>
Change-Id: I2ae048a24c9c68e73ab0086cf05d327eb375856d

5 years agoFix LOGS_SERVER to not be required 46/15646/2
Andrew Grimberg [Mon, 13 May 2019 20:05:10 +0000 (13:05 -0700)]
Fix LOGS_SERVER to not be required

Change 0251b7fda7266760bd82a6e56a696160822a57a0 added in a regression
that forces LOGS_SERVER to be defined when it is not supposed to be
required for jobs.

Change-Id: I3800371e831616c9e9332d0a43e3721d8580a834
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
5 years agogerrit-tox-verify: Allow skip-vote configuration 56/15556/3
Alexandru Avadanii [Wed, 8 May 2019 14:54:00 +0000 (16:54 +0200)]
gerrit-tox-verify: Allow skip-vote configuration

Add a new parameter controlling whether the Jenkins Gerrit Trigger
plugin should vote depending on the build outcome.

Change-Id: I0197b2df19e303a813df91e4c4e6120cc79456fc
Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
5 years agoHandle multiple search extension passed by JJB 31/15631/3
Anil Belur [Mon, 13 May 2019 09:05:24 +0000 (19:05 +1000)]
Handle multiple search extension passed by JJB

`lftools deploy archives` implementation supports '-p|--pattern'
as a multi-value option and does not support processing
multi-values as a single string.

Handle multiple search extension / patterns passed by upstream
${ARCHIVE_ARTIFACTS} param as a single string by spliting these values
before being passed to `lftools deploy archive`.

Issue: RELENG-2013
Change-Id: Id524a291a7fe03ea6f518def94b0f4ebf0974164
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
5 years agoPin pygments to 2.3.x 01/15601/1
Andrew Grimberg [Fri, 10 May 2019 19:03:21 +0000 (12:03 -0700)]
Pin pygments to 2.3.x

Pygments release 2.4.0 which added a python requires that excludes all
versions of Python < 3.5. The LFCI's default 3 version is 3.4 so causes
build failure.

Change-Id: Ide6d0da7357326c64153f0f74f328cee98429344
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
5 years agoAdd missing file path triggers to maven stage jobs 20/15520/5
Lott, Christopher (cl778h) [Sat, 4 May 2019 10:59:42 +0000 (06:59 -0400)]
Add missing file path triggers to maven stage jobs

Add missing config for triggering on file paths to maven stage macros and
templates, namely gerrit_trigger_file_paths and github_included_regions,
to match the behavior of the maven verify/merge macros and templates.

Change-Id: I5ecbdb99e15d8f80250e4081f98a17c630ee5e72
Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
5 years agoAdd submodule-disable for submodule operations 97/15497/1
Alexandru Avadanii [Tue, 23 Apr 2019 17:03:58 +0000 (19:03 +0200)]
Add submodule-disable for submodule operations

Some Akraino projects using git scm have a large number of submodules
which are not required during most CI/CD operations (e.g. we don't
want to fetch GBs of 3rd party repositories when linting the code).

Add submodule-disable parameter for both lf-infra-gerrit-scm
and lf-infra-github-scm, allowing us to disable submodule fetching
where needed.

Jenkins git plugin support for this was added in [1].

This change is very similar and mostly based on the addition of the
submodule-timeout parameter in commit 9fdb611f1.

[1] https://issues.jenkins-ci.org/browse/JENKINS-6658

Change-Id: Ia99ba7f353a39e55d7bec57778f447f94402b5e6
Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
5 years agoInvoke mvn goal 'install' not deploy in new verify job 84/15484/1 v0.37.2
Lott, Christopher (cl778h) [Thu, 2 May 2019 15:58:18 +0000 (11:58 -0400)]
Invoke mvn goal 'install' not deploy in new verify job

Change-Id: I2ac52d56c5ede921d39e6a12ae06d888916be14b
Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
5 years agoRemove maven-versions-plugin-set-version var 63/15463/1 v0.37.1
Lott, Christopher (cl778h) [Wed, 1 May 2019 10:30:36 +0000 (06:30 -0400)]
Remove maven-versions-plugin-set-version var

Clean up newly added maven-docker-stage macro that missed a recent change.
This is a variable that does not need to be defined by the users of the jobs.
The version needed in this builder step is inherited from versions.properties
as "release_version". This also helps teams not having to define this version
in 2 places and just rely on version.properties.

Change-Id: I41083ed784982b904e12edf52d1f8e73a249b13d
Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
5 years agoMerge "Define maven + docker verify, merge and stage jobs" v0.37.0
Anil Belur [Wed, 1 May 2019 03:47:36 +0000 (03:47 +0000)]
Merge "Define maven + docker verify, merge and stage jobs"

5 years agoDefine maven + docker verify, merge and stage jobs 71/15371/12
Lott, Christopher (cl778h) [Wed, 1 May 2019 03:32:13 +0000 (13:32 +1000)]
Define maven + docker verify, merge and stage jobs

This generalizes work first done for Acumos Java projects
that build a Spring-Boot application into a Docker image,
and do not need to deploy any jar libraries or POM files.

Change-Id: Id8040fe2d32ffe4f682f80ec5c4ed60327ef56bd
Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
5 years agoRemove maven-versions-plugin-set-version var 52/15452/3
Jessica Wagantall [Tue, 30 Apr 2019 00:31:14 +0000 (17:31 -0700)]
Remove maven-versions-plugin-set-version var

This is a variable that does not need to be defined by the users
of the jobs. The version needed in this builder step is inherited
from versions.properties as "release_version" and it is fixed as
that.
This also helps teams not having to define this version in 2
places and just rely on version.properties.
This upgrade only affects projects using maven-versions-plugin
to update their versions (ONAP).

Change-Id: I6393291eb555ed0b8f5220264688193c1af9fd5f
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoUpdate jenkins-init script example 16/15416/1
Tim Johnson [Thu, 25 Apr 2019 15:18:36 +0000 (08:18 -0700)]
Update jenkins-init script example

Update example jenking-init script to send stdout/stderr to a file.

Change-Id: I5a91858d1724da41139255f2314c2c6f691070de
Signed-off-by: Tim Johnson <tijohnson@linuxfoundation.org>
5 years agoMerge "Make stripping of "SNAPSHOT" in poms optional"
Andrew Grimberg [Thu, 25 Apr 2019 21:18:15 +0000 (21:18 +0000)]
Merge "Make stripping of "SNAPSHOT" in poms optional"

5 years agoMake stripping of "SNAPSHOT" in poms optional 63/15363/4
Jessica Wagantall [Mon, 22 Apr 2019 21:42:08 +0000 (14:42 -0700)]
Make stripping of "SNAPSHOT" in poms optional

When maven-versions-plugin is set to "true", the job will
use the versions plugin to update the versions in the pom.xml
files and will not need this step in maven-patch-release.sh to
happen.
This change DOES NOT affect current jobs which do not use the
maven versions plugin as this variable is set to false by default.
Update maven-versions-plugin variable in the parameters to be able
to parse the value in the scripts.

Change-Id: Ic25197012fd0f23a859159bb86369feb8a02b9c2
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoFix warning generated by deprecated syntax 92/15392/1
Tim Johnson [Thu, 25 Apr 2019 00:08:25 +0000 (17:08 -0700)]
Fix warning generated by deprecated syntax

Change-Id: Ib8ad97621527ec9869fdc743490706d9c9957df2
Signed-off-by: Tim Johnson <tijohnson@linuxfoundation.org>
5 years agoMove Maven Central staging docs 75/15375/1
Andrew Grimberg [Wed, 24 Apr 2019 15:30:35 +0000 (08:30 -0700)]
Move Maven Central staging docs

The Maven CLM job docs had the staging variables for Maven Central
defined in it instead of in the Maven Stage job docs. This is both
confusing, and incorrect!

Change-Id: Icb05a8d717f1120ec30fa0c523295fe88f3fdcb7
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
5 years agoReduce output in log files 44/15244/8
Tim Johnson [Tue, 9 Apr 2019 21:41:20 +0000 (14:41 -0700)]
Reduce output in log files

Previously ran 'pip freeze' (> log) twice to get list of pip packages
installed during build.  Run 'pip list' (> file) twice and archive the
files and diffs. Configured 'logs-deploy.sh' to run as separate Jekins
script.

Issue: RELENG-1902
Change-Id: Ib0f99bd1eb125015467c7eaf91d26c76e92bffa0
Signed-off-by: Tim Johnson <tijohnson@linuxfoundation.org>
5 years agoFix execute permissions 56/15356/4
Tim Johnson [Sat, 20 Apr 2019 18:53:55 +0000 (11:53 -0700)]
Fix execute permissions

Change-Id: I253ed35ec78f51d4b2352539d2d24260edde5459
Signed-off-by: Tim Johnson <tijohnson@linuxfoundation.org>
5 years agoMerge "Upgrade packer version to 1.4.0"
Thanh Ha (zxiiro) [Mon, 22 Apr 2019 11:15:16 +0000 (11:15 +0000)]
Merge "Upgrade packer version to 1.4.0"

5 years agoFix gerrit-packer-merge choosing strategy 54/15354/1
Andrew Grimberg [Fri, 19 Apr 2019 21:48:01 +0000 (14:48 -0700)]
Fix gerrit-packer-merge choosing strategy

Our definition of a merge job is that it always takes the HEAD of the
branch. Gerrit Trigger choosing strategy does not do this and breaks
expected outcomes when retriggering an old merge.

Change-Id: I2e3c12f1c9b59e624e742943a5dbef5123129e6c
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
5 years agoUpgrade packer version to 1.4.0 47/15347/1
Andrew Grimberg [Fri, 19 Apr 2019 18:34:37 +0000 (11:34 -0700)]
Upgrade packer version to 1.4.0

The next release of common-packer requires packer 1.3.2 or greater.
Update to 1.4.0 as it is the current release and has been verified to
work properly.

Change-Id: Iec56190d26ff98dfaf5df1346dc82e7995ab640c
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
5 years agoAdd missing script name markers 84/15284/1
Anil Belur [Mon, 15 Apr 2019 11:09:11 +0000 (21:09 +1000)]
Add missing script name markers

Add missing script name markers useful in console logs.

Change-Id: I3c0768d3d5def6258bb8a5e556d78b4836fa957e
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
5 years agoUpdate lftools to v0.23.1 65/15265/1 v0.36.0
Anil Belur [Fri, 12 Apr 2019 01:17:16 +0000 (11:17 +1000)]
Update lftools to v0.23.1

Change-Id: I4289796af1e455a6ab1f6e59b29da60d46b6b1d1
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
5 years agoMerge "Add lf-infra-wss-mvn-clean-install step"
Jessica Wagantall [Thu, 11 Apr 2019 21:35:22 +0000 (21:35 +0000)]
Merge "Add lf-infra-wss-mvn-clean-install step"

5 years agoUpdate jenkins-cfg-verify to use $GERRIT_REFSPEC 63/15263/4
Anil Belur [Thu, 11 Apr 2019 12:29:45 +0000 (22:29 +1000)]
Update jenkins-cfg-verify to use $GERRIT_REFSPEC

Update jenkins-cfg to verify images names updated from the
$GERRIT_REFSPEC instead of the master branch.

Current implementation uses the 'master' branch instead of
the $GERRIT_REFSPEC, therefore failing the verify job
on false positives.

Issue: RELENG-1950
Change-Id: I6f212b28e4189ff5c7958035c7992b55d7153d02
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
5 years agoAdd lf-infra-wss-mvn-clean-install step 61/15261/3
Jessica Wagantall [Thu, 11 Apr 2019 05:14:13 +0000 (22:14 -0700)]
Add lf-infra-wss-mvn-clean-install step

Add Maven clean install conditional step
that runs before WhiteSource Unified Agent scan.
This allows to fetch additional dependencies.

Issue: RELENG-1951
Change-Id: Id3e070220e17ba995d976b3d033a16983b38fd8d
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoHardcode WSS project version 59/15259/4
Jessica Wagantall [Thu, 11 Apr 2019 00:16:16 +0000 (17:16 -0700)]
Hardcode WSS project version

Similarly to how is done in CLM, the WhiteSource
versions for projects should reflect the branch they are
running on.

Also fix script variables to be enclosed by "{}".

Change-Id: Ica0a52adcc9223e861f213bc53c67ed2102efda5
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoUse WS Agent config file internally 58/15258/3
Jessica Wagantall [Wed, 10 Apr 2019 23:37:51 +0000 (16:37 -0700)]
Use WS Agent config file internally

After checking with legal, it was agreed to not
allow tech teams to provide their own
wss-unified-agent.config file for WhiteSource scans.
Instead, this file should be managed in Jenkins Settings
Files

Change-Id: I20e330794ba28cb4c0f5206c290a734c1794b00e
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoMerge "Fixes for info votes"
Aric Gardner [Tue, 9 Apr 2019 17:31:24 +0000 (17:31 +0000)]
Merge "Fixes for info votes"

5 years agoMerge "Add missing release notes."
Aric Gardner [Tue, 9 Apr 2019 17:29:36 +0000 (17:29 +0000)]
Merge "Add missing release notes."

5 years agoFixes for info votes 01/15201/3
Aric Gardner [Thu, 4 Apr 2019 19:56:01 +0000 (15:56 -0400)]
Fixes for info votes

gerrit trigger is not working in opnfv.
we had this happen to some of the read the docs jobs...
An updgrade of gerrit is planned to hopefully resolve this.

Not sure were to test to approval category stuff.
That said I think the mistake is that the value is an int.

            approval-category: 'WHATEVER'
            approval-value: 2

I dont actually want the script to exit on first error, need to output
the vote verdict.

not sure why I thought that JENKINS_SSH_CREDENTIAL
was the correct var for the ssh user.
switched to $USER

Change-Id: I6714361423948eb1764e9c18da699dafd4cd24a9
Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
5 years agoAdd missing release notes. 28/15228/2
Aric Gardner [Mon, 8 Apr 2019 17:36:03 +0000 (13:36 -0400)]
Add missing release notes.

Commit b2e2b5b7d3bb61ee9886debb4e010769c35be398
was missing release notes.

Change-Id: If6adc956f92113e80177930b82ba20872b4e009f
Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
5 years agoUpdate rtd-merge to also trigger on tag changes 27/15227/1
Thanh Ha [Mon, 8 Apr 2019 03:41:07 +0000 (11:41 +0800)]
Update rtd-merge to also trigger on tag changes

When we release a tag, it should also trigger a rtd-merge build
so that the doc release note link is updated appropriately.

Change-Id: I49f6555b707018cca4042917c4193138456dafeb
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoARM64 support for update-java-alternatives 11/15211/1
Martin Klozik [Fri, 5 Apr 2019 14:05:07 +0000 (16:05 +0200)]
ARM64 support for update-java-alternatives

Java paths at Ubuntu contain host CPU architecture signature.
Script was updated to correctly detect architecture by dpdk.

Change-Id: I77c4aba1d600373edff283b6b85837fccda3af34
Signed-off-by: Martin Klozik <martin.klozik@tieto.com>
5 years agoFix bug in package-listing start script 07/15207/1
Andrew Grimberg [Thu, 4 Apr 2019 22:39:32 +0000 (15:39 -0700)]
Fix bug in package-listing start script

Change af89ef784234e7b89984d5b2995fc6d29b6d8c34 introduced a bug where
we don't make sure that the package-listing.sh script is executable
before calling it during system startup. This means that we are no
longer currently producing the needed listing start file for instances
to be able to diff against to give us a view of package changes.

Change-Id: Iea2f0b07cdf10f7819072bcb00596bdeda4665df
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
5 years agoMerge "Fix global-jjb docs for installation"
Jessica Wagantall [Thu, 4 Apr 2019 21:15:38 +0000 (21:15 +0000)]
Merge "Fix global-jjb docs for installation"

5 years agoFix global-jjb docs for installation 00/15200/4
Andrew Grimberg [Thu, 4 Apr 2019 19:32:10 +0000 (12:32 -0700)]
Fix global-jjb docs for installation

The docs copy / paste script use the GitHub submodule but don't properly
name the resultant module to match the expectations of the rest of the
script.

Fix up some minor inconsistencies / errors of other parts of script

Change-Id: I66402d9ef1be80c1dd53c51d55802a864c813421
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
5 years agoMerge "Add WhiteSource Scan jobs"
Jessica Wagantall [Thu, 4 Apr 2019 19:59:03 +0000 (19:59 +0000)]
Merge "Add WhiteSource Scan jobs"

5 years agoAdd WhiteSource Scan jobs 97/14997/10
Jessica Wagantall [Fri, 22 Mar 2019 00:56:15 +0000 (17:56 -0700)]
Add WhiteSource Scan jobs

WhiteSource is an open source security and license compliance
management platform.
It is used to scan a great variety of languages includding Java,
Python, C, Go, among others.

{project-name}-whitesource-scan-{stream} uses WhiteSource's
Unified Agent to perform the code scans.

Issue: RELENG-1876
Change-Id: If511da2f51e08799352ee6841338f76dd63af6b6
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoUpdate lftools to version v0.22.2 83/15183/1 v0.35.0
Aric Gardner [Wed, 3 Apr 2019 17:47:34 +0000 (13:47 -0400)]
Update lftools to version v0.22.2

Change-Id: Ic1e44a73813dd42c9b376547cc4814f1d63b6ab4
Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
5 years agoMerge "INFO.yaml check vote for global-jjb"
Andrew Grimberg [Wed, 3 Apr 2019 16:26:30 +0000 (16:26 +0000)]
Merge "INFO.yaml check vote for global-jjb"

5 years agoAdd comment-to-gerrit macro 73/15173/2
Aric Gardner [Tue, 2 Apr 2019 18:28:57 +0000 (14:28 -0400)]
Add comment-to-gerrit macro

This macro will post a comment to the gerrit patchset if the build
creates a file named gerrit_comment.txt
To use this macro add it to the list of builders

Change-Id: I30e2b10fc4e09f534b161dd99775d66bdc4c3e1a
Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
5 years agoINFO.yaml check vote for global-jjb 35/15035/12
Aric Gardner [Mon, 25 Mar 2019 20:35:34 +0000 (16:35 -0400)]
INFO.yaml check vote for global-jjb

Global job per gerrit, that triggers on changes
to INFO.yaml file

And auto merged if a majority of committers
have voted.

This will create a review in the internal gerrit

If a tsc vote is required, RE must manually confirm
that this has happened.

We will need to give
Non-Interactive Users merge
or perhaps specifically only the jenkins
user.

Job will only trigger when a user votes +2
cludgy but it works.

Example of Job configuration:

- project:
    name: info-vote
    build-node: centos7-builder-2c-1g
    jobs:
      - 'info-vote-verify'

Change-Id: Ib386bd2ea51be113ca59610bd3281b9ad6923bce
Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
5 years agoRevert Add tox-verify job to the default ci group 63/15163/2
Bengt Thuree [Tue, 2 Apr 2019 00:45:41 +0000 (17:45 -0700)]
Revert Add tox-verify job to the default ci group

This reverts commit 059f6382bcbe1549201773eb4d881d43724ca8a9.

Merged it to quickly, need to ensure all projects has tox.ini
and .coafile linting in place first.

Change-Id: I083fcb526d1858d15decb58d4138f9dcc9cc600a
Signed-off-by: Bengt Thuree <bthuree@linuxfoundation.org>
5 years agoMerge "Add tox-verify job to the default ci group"
Bengt Thuree [Tue, 2 Apr 2019 00:40:16 +0000 (00:40 +0000)]
Merge "Add tox-verify job to the default ci group"

5 years agoAllow jjb-workers to be configurable 88/15088/1
Thanh Ha [Wed, 27 Mar 2019 17:27:19 +0000 (13:27 -0400)]
Allow jjb-workers to be configurable

Default it to the number of CPU cores available on the system.

Issue: RELENG-917
Change-Id: I5f65ec7d7142f1a778b6e31cc6700ca2bca1ef88
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoSkip creating source jars in verify job 87/15087/1
Thanh Ha [Wed, 27 Mar 2019 17:16:03 +0000 (13:16 -0400)]
Skip creating source jars in verify job

Issue: RELENG-1655
Change-Id: Ibd2aad63afda3feb97619cef67c10c8b665cd924
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoAdd tox-verify job to the default ci group 81/12681/2
Thanh Ha [Thu, 20 Sep 2018 15:16:01 +0000 (11:16 -0400)]
Add tox-verify job to the default ci group

This ensures our projects are running linters against the prjoect.

Change-Id: I5ce38eeecef8f1241a49dfe7da3eb04fec7ac385
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoUpdate lftools to version v0.22.1 41/15041/1 v0.34.1
Anil Belur [Tue, 26 Mar 2019 02:05:30 +0000 (12:05 +1000)]
Update lftools to version v0.22.1

Change-Id: I728e3581f956cd56cc0446f2a3360bd9e71df6af
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
5 years agoUpdate lftools to version 0.22.0 96/14996/1 v0.34.0
Anil Belur [Thu, 21 Mar 2019 23:28:14 +0000 (09:28 +1000)]
Update lftools to version 0.22.0

Change-Id: I545662ee1cf31e1609971c08bb75555acf384139
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
5 years agoMerge "Fix JAVA_HOME for CentOS7"
Anil Belur [Thu, 21 Mar 2019 21:41:00 +0000 (21:41 +0000)]
Merge "Fix JAVA_HOME for CentOS7"

5 years agoFix JAVA_HOME for CentOS7 85/14985/4
Vanessa Rene Valderrama [Wed, 20 Mar 2019 20:15:27 +0000 (15:15 -0500)]
Fix JAVA_HOME for CentOS7

JAVA_HOME for JDK-11 on CentOS7 is set to /opt/jdk-11 but JDK-11 is
installing in /usr/lib/jvm/java-11-openjdk/.

This change is to modify JAVA_HOME to use the correct path and install
JDK-11 properly.

Change-Id: I598a063988a5afea5d6827d0940fdcbd2b83e99a
Signed-off-by: Vanessa Rene Valderrama <vvalderrama@linuxfoundation.org>
5 years agoAdd Throttle Property to JJB jobs 81/14781/4
Trevor Bramwell [Fri, 9 Nov 2018 05:43:54 +0000 (21:43 -0800)]
Add Throttle Property to JJB jobs

This adds "Throttle Builds" configuration to JJB jobs (verify, merge,
etc) to allow global-jjb users with static builders to limit the number
of jjb jobs ran on a single node.

Issue: RELENG-1510
Change-Id: I00d2950451eae8037ded407937131723b0001179
Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
5 years agoAdapt maven path search for files and dirs 68/14968/3
Eric Ball [Wed, 20 Mar 2019 00:51:34 +0000 (17:51 -0700)]
Adapt maven path search for files and dirs

The "-f" maven param can specify both a directory, in which case it
will look for "pom.xml" in the directory, or a specific file. The
original version of this search was only compatible with directories
that contain a pom.xml file.

Change-Id: I81ab161f3156fc2159a4b7ca9ca084a0f82da795
Signed-off-by: Eric Ball <eball@linuxfoundation.org>
5 years agoMerge "Extract version number passed set '{java-version}'"
Anil Belur [Wed, 20 Mar 2019 21:50:01 +0000 (21:50 +0000)]
Merge "Extract version number passed set '{java-version}'"