From: Lott, Christopher (cl778h) <cl778h@att.com>
Date: Fri, 1 Nov 2019 18:02:09 +0000 (-0400)
Subject: Use compare-type REG_EXP for Python job file paths
X-Git-Tag: v0.48.0~7
X-Git-Url: https://gerrit.linuxfoundation.org/infra/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F45%2F62145%2F2;hp=19cb59a5d60873873f6905b97266a8e919796dbc;p=releng%2Fglobal-jjb.git

Use compare-type REG_EXP for Python job file paths

Change compare-type to REG_EXP in macros lf_python_clm_xc and
lf_pypi_common for config parameter gerrit_trigger_file_paths
with the regular expression .*
Previously was ANT, which didn't match anything with pattern .*
so recheck/reverify comment triggers did not work.
Clarify documentation of comment triggers for python jobs.

Change-Id: Id926d83e454fce2aa795b15d27c794fc41bbd1d3
Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
---

diff --git a/docs/jjb/lf-python-jobs.rst b/docs/jjb/lf-python-jobs.rst
index 217a7b35..bf09c613 100644
--- a/docs/jjb/lf-python-jobs.rst
+++ b/docs/jjb/lf-python-jobs.rst
@@ -65,7 +65,9 @@ to access Nexus IQ Server.
     - gerrit-python-xc-clm
     - github-python-xc-clm
 
-:Comment Trigger: run-clm
+:Comment Trigger: **run-clm** post a comment with the trigger to launch
+    this job manually. Do not include any additional text or vote in the
+    same comment.
 
 :Required parameters:
 
@@ -147,7 +149,9 @@ https://docs.sonarqube.org/display/PLUG/Python+Coverage+Results+Import
     - gerrit-tox-sonar
     - github-tox-sonar
 
-:Comment Trigger: run-sonar
+:Comment Trigger: **run-sonar** post a comment with the trigger to launch
+    this job manually. Do not include any additional text or vote in the
+    same comment.
 
 :Required parameters:
 
@@ -229,7 +233,9 @@ variables before running.
     - gerrit-tox-verify
     - github-tox-verify
 
-:Comment Trigger: recheck|reverify
+:Comment Trigger: **recheck|reverify** post a comment with one of the
+    triggers to launch this job manually. Do not include any additional
+    text or vote in the same comment.
 
 :Required Parameters:
 
@@ -288,7 +294,9 @@ variables before running.
     - gerrit-tox-merge
     - github-tox-merge
 
-:Comment Trigger: remerge
+:Comment Trigger: **remerge** post a comment with the trigger to launch
+    this job manually. Do not include any additional text or vote in the
+    same comment.
 
 :Required Parameters:
 
@@ -349,7 +357,9 @@ pyenv variables before running.
     - gerrit-pypi-verify
     - github-pypi-verify
 
-:Comment Trigger: recheck
+:Comment Trigger: **recheck|reverify** post a comment with one of the
+    triggers to launch this job manually. Do not include any additional
+    text or vote in the same comment.
 
 :Required Parameters:
 
@@ -439,7 +449,9 @@ the repository key-value pair is optional, it defaults to pypi.org.
     - gerrit-pypi-merge
     - github-pypi-merge
 
-:Comment Trigger: remerge
+:Comment Trigger: **remerge** post a comment with the trigger to launch
+    this job manually. Do not include any additional text or vote in the
+    same comment.
 
 :Required Parameters:
 
diff --git a/jjb/lf-python-jobs.yaml b/jjb/lf-python-jobs.yaml
index 606d5ec1..fe06d71c 100644
--- a/jjb/lf-python-jobs.yaml
+++ b/jjb/lf-python-jobs.yaml
@@ -90,7 +90,7 @@
     submodule-disable: false
 
     gerrit_trigger_file_paths:
-      - compare-type: ANT
+      - compare-type: REG_EXP
         pattern: ".*"
 
     # github_included_regions MUST match gerrit_trigger_file_paths
@@ -682,7 +682,7 @@
     tox-envs: ""
 
     gerrit_trigger_file_paths:
-      - compare-type: ANT
+      - compare-type: REG_EXP
         pattern: ".*"
 
     # github_included_regions MUST match gerrit_trigger_file_paths
diff --git a/releasenotes/notes/fix-pypi-compare-type-a3ae65287c42d2d3.yaml b/releasenotes/notes/fix-pypi-compare-type-a3ae65287c42d2d3.yaml
new file mode 100644
index 00000000..cc9c56d4
--- /dev/null
+++ b/releasenotes/notes/fix-pypi-compare-type-a3ae65287c42d2d3.yaml
@@ -0,0 +1,10 @@
+---
+fixes:
+  - |
+
+    Change compare-type to REG_EXP in macros lf_python_clm_xc and
+    lf_pypi_common for config parameter gerrit_trigger_file_paths
+    with the regular expression .*
+    Previously was ANT, which didn't match anything with pattern .*
+    so recheck/reverify comment triggers did not work.
+    Clarify documentation of comment triggers for python jobs.