From: Andrew Grimberg <agrimberg@linuxfoundation.org>
Date: Wed, 26 Jun 2019 20:23:59 +0000 (-0700)
Subject: Revert plugin listing print change
X-Git-Tag: v0.25.1^0
X-Git-Url: https://gerrit.linuxfoundation.org/infra/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F06%2F16006%2F7;p=releng%2Flftools.git

Revert plugin listing print change

Change 5df955f24bc0154f7069ecfc188311052e67febc had a minor change that
slipped through the code review changing the Jenkins plugin listing from
long names to using the short names. This however, is not utilized at
all by the security listing function that was the primary portion of
this change.

This modification causes the jenkins configuration management merge job
to fail on updates to the OpenStack cloud configuration.

Change-Id: I04cfbfe5a49904875a734e223bda13c6164df664
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
---

diff --git a/lftools/cli/jenkins/plugins.py b/lftools/cli/jenkins/plugins.py
index 283da214..f55d9822 100644
--- a/lftools/cli/jenkins/plugins.py
+++ b/lftools/cli/jenkins/plugins.py
@@ -22,8 +22,8 @@ def checkmark(truthy):
     return u'\u2717'
 
 
-def print_plugin(plugin, namefield='shortName'):
-    """Print the plugin shortName and version."""
+def print_plugin(plugin, namefield='longName'):
+    """Print the plugin longName and version."""
     print("%s:%s" % (plugin[namefield], plugin['version']))
 
 
diff --git a/releasenotes/notes/revert-plugin-list-change-0686578ef029edcc.yaml b/releasenotes/notes/revert-plugin-list-change-0686578ef029edcc.yaml
new file mode 100644
index 00000000..86ea5ac0
--- /dev/null
+++ b/releasenotes/notes/revert-plugin-list-change-0686578ef029edcc.yaml
@@ -0,0 +1,7 @@
+---
+critical:
+  - |
+    A problem was found with the Jenkins OpenStack cloud configuration job
+    routines that were relying on the long name form of installed plugins. As
+    the long name form is more human friendly we are reverting to that
+    configuration.