From: Andrew Grimberg <agrimberg@linuxfoundation.org>
Date: Thu, 12 Jul 2018 22:44:25 +0000 (-0700)
Subject: Fix ShellCheck warnings for signing script
X-Git-Tag: v0.14.0~4
X-Git-Url: https://gerrit.linuxfoundation.org/infra/gitweb?a=commitdiff_plain;h=bbed6f5483a4f09773933cfa6ab3c3bdc05a93b4;p=releng%2Flftools.git

Fix ShellCheck warnings for signing script

In prepration for adding sigul signing, the shellcheck warnings need to
be cleaned up

Change-Id: I27479a28f2a7898e489c8a2198ffbf8cdea0cbef
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
---

diff --git a/shell/sign b/shell/sign
index 84a6fc81..711f6057 100755
--- a/shell/sign
+++ b/shell/sign
@@ -73,13 +73,15 @@ sign_dir() {
 
     if hash parallel 2>/dev/null; then
         echo "Signing in parallel..."
+        # We need to wordsplit ${files_to_sign[*]} so disable quoting check
+        # shellcheck disable=SC2086
         parallel --no-notice --jobs 200% --halt now,fail=1 \
             "$GPG_BIN --batch -abq {}" ::: ${files_to_sign[*]}
 
         echo "Signed the following files:"
         printf '%s\n' "${files_to_sign[@]}"
     else
-        echo "GNU `parallel` not found. Signing in serial mode..."
+        echo "GNU parallel not found. Signing in serial mode..."
         for f in "${files_to_sign[@]}"; do
             echo "Signing $f"
             "$GPG_BIN" --batch -abq "$f"