From: Thanh Ha <thanh.ha@linuxfoundation.org>
Date: Thu, 8 Jun 2017 01:33:43 +0000 (-0400)
Subject: Fix shellcheck warnings
X-Git-Tag: v0.3.0~9
X-Git-Url: https://gerrit.linuxfoundation.org/infra/gitweb?a=commitdiff_plain;h=56864adf9a6062190e4b9bedc2944cb6a95f8014;p=releng%2Fglobal-jjb.git

Fix shellcheck warnings

- SC2196: egrep is deprecated use grep -E instead.
- SC2086: Double quote to prevent word globbing.

Change-Id: I466ebf8f890fbc9e1047624345cc93d9f58ad5a0
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
---

diff --git a/shell/gpg-verify-git-signature.sh b/shell/gpg-verify-git-signature.sh
index b26359e6..1f473368 100644
--- a/shell/gpg-verify-git-signature.sh
+++ b/shell/gpg-verify-git-signature.sh
@@ -10,7 +10,7 @@
 ##############################################################################
 echo "---> gpg-verify-git-signature.sh"
 
-if git log --show-signature -1 | egrep -q 'gpg: Signature made.*key ID'; then
+if git log --show-signature -1 | grep -E -q 'gpg: Signature made.*key ID'; then
    echo "Git commit is GPG signed."
 else
    echo "WARNING: GPG signature missing for the commit."
diff --git a/shell/logs-clear-credentials.sh b/shell/logs-clear-credentials.sh
index 8ebb5a6f..15003e1d 100644
--- a/shell/logs-clear-credentials.sh
+++ b/shell/logs-clear-credentials.sh
@@ -10,5 +10,5 @@
 ##############################################################################
 
 # Clear log credential files
-rm $SETTINGS_FILE
+rm "$SETTINGS_FILE"
 rm ~/.netrc