From: Anil Belur <abelur@linuxfoundation.org>
Date: Thu, 19 Dec 2019 22:18:47 +0000 (+1000)
Subject: Remove coala from common-packer
X-Git-Tag: v0.4.0~4
X-Git-Url: https://gerrit.linuxfoundation.org/infra/gitweb?a=commitdiff_plain;h=45b0f4a0d4d3fe2e5eb6363b31b0e1d033f0cc58;p=releng%2Fcommon-packer.git

Remove coala from common-packer

Move away from coala since that project refuses to produce any
new release and the version we're using is quite dated at this
point.

Coala does not seem to be working well with prettier pre-commit
hook in place, since prettier is auto-formating the yaml code
to make the code terse which fails the tox verify job.

Issue: RELENG-2641
Change-Id: I8d782822ca87add9108a044fd6e19b1c23686717
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
---

diff --git a/.coafile b/.coafile
deleted file mode 100644
index 2f3d846..0000000
--- a/.coafile
+++ /dev/null
@@ -1,42 +0,0 @@
-[all]
-ignore = .tox/**,
-    .git/**,
-    .gitignore,
-    .gitreview,
-    .gitmodules,
-    node_modules/**,
-    **.sw?,
-    **.orig
-
-[all.Documentation]
-bears = SpaceConsistencyBear,WriteGoodLintBear
-files = docs/**.rst
-use_spaces = true
-
-[all.GitCommit]
-bears = GitCommitBear
-ignore_length_regex = Signed-off-by,
-    Also-by,
-    Co-authored-by,
-    http://,
-    https://
-
-[JSON]
-bears = JSONFormatBear
-files = templates/**.json,
-    vars/**.json
-indent_size = 2
-
-[all.ShellCheck]
-bears = ShellCheckBear, SpaceConsistencyBear, LineLengthBear
-files = provision/**.sh, ansible-galaxy.sh
-shell = bash
-indent_size = 4
-use_spaces = True
-max_line_length = 80
-
-[YAML]
-bears = YAMLLintBear
-files = provision/**.yaml
-document_start = True
-yamllint_config = .yamllint.conf
diff --git a/tox.ini b/tox.ini
index a3481af..5bff9ee 100644
--- a/tox.ini
+++ b/tox.ini
@@ -1,25 +1,9 @@
 [tox]
 minversion = 1.6
 envlist =
-    coala,
     pre-commit
 skipsdist = true
 
-[testenv:coala]
-basepython = python3
-deps =
-    coala
-    coala-bears
-    pygments~=2.3.1
-    # request-2.22.0 does not work with python-3.4.9
-    requests~=2.21.0
-    nodeenv==1.1.2
-commands =
-    nodeenv -p
-    npm install --global write-good
-    python3 -m nltk.downloader punkt maxent_treebank_pos_tagger averaged_perceptron_tagger
-    coala --non-interactive
-
 [testenv:docs]
 basepython = python3
 deps = -rdocs/requirements.txt