Add protection in python-tools-install.sh 50/67550/1
authorGuillaume Lambert <guillaume.lambert@orange.com>
Mon, 3 May 2021 13:22:38 +0000 (15:22 +0200)
committerGuillaume Lambert <guillaume.lambert@orange.com>
Mon, 3 May 2021 13:36:01 +0000 (15:36 +0200)
This script may result in unexpected behavior on distributions
other than Ubuntu with a matching release.
DISTRIB_ID must be tested to avoid such problems.

Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: I2ba02b613a4aaadfeb09bd66ddfde8f36a9510b4

shell/python-tools-install.sh

index 5978305..e0e4eec 100644 (file)
@@ -45,7 +45,7 @@ EOF
     if [[ -f /etc/lsb-release ]]; then
        # shellcheck disable=SC1091
        source /etc/lsb-release
-       if [[ $DISTRIB_RELEASE == "16.04" ]]; then
+       if [[ $DISTRIB_RELEASE == "16.04" && $DISTRIB_ID == "Ubuntu" ]]; then
          echo "WARNING: Python projects should move to Ubuntu 18.04 to continue receiving support"
          echo "zipp==1.1.0" >> "$requirements_file"
        fi