Use coala got run ShellCheck

Change-Id: I7ea7346fb2cacb5310293a3b2dbdc1e6261dbab0
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

diff --git a/.coafile b/.coafile
new file mode 100644 (file)
index 0000000..63256b1
--- /dev/null
+++ b/.coafile
@@ -0,0 +1,4 @@
+[ShellCheck]
+bears = ShellCheckBear
+files = shell/*
+shell = bash

diff --git a/requirements.txt b/requirements.txt
index b05dd8a..76616bd 100644 (file)
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,3 +1,2 @@
 sphinx>=1.4.9
 sphinx_bootstrap_theme>=0.4.14
-

diff --git a/run_shellcheck b/run_shellcheck
deleted file mode 100755 (executable)
index c134a94..0000000
--- a/run_shellcheck
+++ /dev/null
@@ -1,8 +0,0 @@
-#!/bin/bash
-
-command -v shellcheck >/dev/null 2>&1 || {
-    echo >&2 "ShellCheck is not installed. Please install using your favourite package manager."
-    exit 1
-}
-
-shellcheck shell/*

diff --git a/tox.ini b/tox.ini
index 5f18c0d..18e4aa9 100644 (file)
--- a/tox.ini
+++ b/tox.ini
@@ -1,6 +1,17 @@
 [tox]
 minversion = 1.6
-envlist = docs,docs-linkcheck,shellcheck
+envlist =
+    coala,
+    docs,
+    docs-linkcheck
+
+[testenv:coala]
+basepython = python3
+deps =
+    coala
+    coala-bears
+commands =
+    coala --non-interactive
 
 [testenv:docs]
 deps = -rrequirements.txt
@@ -12,6 +23,3 @@ whitelist_externals = echo
 [testenv:docs-linkcheck]
 deps = -rrequirements.txt
 commands = sphinx-build -b linkcheck -d {envtmpdir}/doctrees ./docs/ {toxinidir}/docs/_build/linkcheck
-
-[testenv:shellcheck]
-commands = ./run_shellcheck