Resolve ShellCheck errors in shell scripts 80/16480/1
authorThanh Ha <zxiiro@gmail.com>
Thu, 8 Aug 2019 02:32:05 +0000 (22:32 -0400)
committerThanh Ha <zxiiro@gmail.com>
Thu, 8 Aug 2019 03:05:43 +0000 (23:05 -0400)
commitdbd05cd4100a27a545cc2c7f0388018449d982c3
tree9f282849e11da73d6e389d24838b9b65d1dc1d6f
parentb7c2eb944f2ca44bb07a1841306dc75e3e8c03bd
Resolve ShellCheck errors in shell scripts

* SC2086: Double quote to prevent globbing and word splitting.
* SC2027: The surrounding quotes actually unquote this.
          Remove or escape them.
* SC2016: Expressions don't expand in single quotes,
          use double quotes for that.
* SC2236: Use -n instead of ! -z.
* SC2233: Remove superfluous (..) around condition.

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I73207aa87646472bdb1c7848ba9608ac702bda53
23 files changed:
jenkins-init-scripts/create-jenkins-user.sh
shell/cmake-sonar.sh
shell/docker-build.sh
shell/docker-login.sh
shell/docker-push.sh
shell/gerrit-branch-lock.sh
shell/gerrit-push-patch.sh
shell/git-validate-jira-urls.sh
shell/jenkins-configure-clouds.sh
shell/jenkins-configure-global-vars.sh
shell/jenkins-verify-images.sh
shell/jjb-verify-job.sh
shell/maven-fetch-metadata.sh
shell/nexus-iq-cli.sh
shell/openstack-cleanup-orphaned-ports.sh
shell/package-listing.sh
shell/packer-install.sh
shell/puppet-lint.sh
shell/python-tools-install.sh
shell/release-job.sh
shell/rtd-trigger-build.sh
shell/tox-run.sh
shell/whitesource-unified-agent-cli.sh