Code Review / releng / lftools.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 0ef6527) | patch
Fix: Move text/html mimetype check to after None 29/68529/2 v0.35.7
authorEric Ball <eball@linuxfoundation.org>
Fri, 13 Aug 2021 01:40:17 +0000 (18:40 -0700)
committerEric Ball <eball@linuxfoundation.org>
Fri, 13 Aug 2021 01:46:53 +0000 (18:46 -0700)
commitb2835f462d9c072a10afa2c1edc3436855f1231a
tree3489fe75950cc4903c3fd0e526d063b44323c734tree | snapshot
parent0ef6527a0b61c5882bd3176e3c9ceab4511ff4f9commit | diff
Fix: Move text/html mimetype check to after None

When checking mimetype during _upload_to_s3, the newly-added
text/html type was checking before it is checked for None, which is a
potential TypeError.

By moving it after the variable is checked for None, the feature is
safe without requiring any further modifications.

Change-Id: Ia945893adb8973608cb9527b4ea811a5610d6aba
Signed-off-by: Eric Ball <eball@linuxfoundation.org>
lftools/deploy.py diff | blob | history
releasenotes/notes/fix-deploy-mimetype-889dd0182fea051b.yaml [new file with mode: 0644] blob
Release Engineering tools used across Linux Foundation projects