X-Git-Url: https://gerrit.linuxfoundation.org/infra/gitweb?a=blobdiff_plain;f=shell%2Flogs-deploy.sh;h=f4b886908af111f1264e58ba5c24bd22cf70cecf;hb=2dcdf635f5b1d7feffa3af9fe4f15368a0f1ebe7;hp=eae48951f778b6cfbd4193021ba31bd3aa0a5c26;hpb=cfe54b794b3814f288009b796e82668ba8846ca1;p=releng%2Fglobal-jjb.git

diff --git a/shell/logs-deploy.sh b/shell/logs-deploy.sh
index eae48951..f4b88690 100644
--- a/shell/logs-deploy.sh
+++ b/shell/logs-deploy.sh
@@ -10,27 +10,24 @@
 ##############################################################################
 echo "---> logs-deploy.sh"
 
-# Ensure we fail the job if any steps fail.
-set -eu -o pipefail
+# Ensure we fail the job if any steps fail
+# Disable 'globbing'
+set -euf -o pipefail
 
-if [[ -z $LOGS_SERVER ]]; then
+if [[ -z $"${LOGS_SERVER:-}" ]]; then
     echo "WARNING: Logging server not set"
 else
     nexus_url="${NEXUSPROXY:-$NEXUS_URL}"
     nexus_path="${SILO}/${JENKINS_HOSTNAME}/${JOB_NAME}/${BUILD_NUMBER}"
 
     # Handle multiple search extensions as separate values to '-p|--pattern'
-    set -f # Disable pathname expansion
-    IFS=' ' read -r -a search_exts <<< "${ARCHIVE_ARTIFACTS:-}"
+    # "arg1 arg2" -> (-p arg1 -p arg2)
     pattern_opts=()
-    for search_ext in "${search_exts[@]}";
-    do
-        pattern_opts+=("-p" "$search_ext")
+    for arg in ${ARCHIVE_ARTIFACTS:-}; do
+        pattern_opts+=("-p" "$arg")
     done
-
     lftools deploy archives "${pattern_opts[@]}" "$nexus_url" "$nexus_path" \
             "$WORKSPACE"
-    set +f  # Enable pathname expansion
     lftools deploy logs "$nexus_url" "$nexus_path" "${BUILD_URL:-}"
 
     echo "Build logs: <a href=\"$LOGS_SERVER/$nexus_path\">$LOGS_SERVER/$nexus_path</a>"