X-Git-Url: https://gerrit.linuxfoundation.org/infra/gitweb?a=blobdiff_plain;f=shell%2Flftools-install.sh;h=8b1c8f1ba97d53be6a8986431e61d3aa020c24f2;hb=3a0a6bc90e5a9a3a77e4b15ee2c796aef5f216e4;hp=527a7345a018d43ae02ca721325395b316f522a2;hpb=851b0b6d0cfe84e986548fd596a9b2f18413fefd;p=releng%2Fglobal-jjb.git

diff --git a/shell/lftools-install.sh b/shell/lftools-install.sh
index 527a7345..8b1c8f1b 100644
--- a/shell/lftools-install.sh
+++ b/shell/lftools-install.sh
@@ -10,9 +10,19 @@
 ##############################################################################
 echo "---> lftools-install.sh"
 
-virtualenv "$WORKSPACE/.virtualenvs/lftools"
+# Ensure we fail the job if any steps fail.
+# DO NOT set -u as virtualenv's activate script has unbound variables
+set -e -o pipefail
+
+virtualenv --quiet "$WORKSPACE/.virtualenvs/lftools"
 # shellcheck source=./.virtualenvs/lftools/bin/activate disable=SC1091
 source "$WORKSPACE/.virtualenvs/lftools/bin/activate"
-pip install --upgrade pip
-pip install --upgrade "lftools<1.0.0"
-pip freeze
+PYTHON="$WORKSPACE/.virtualenvs/lftools/bin/python"
+$PYTHON -m pip install --quiet --upgrade pip
+$PYTHON -m pip install --quiet --upgrade "lftools<1.0.0"
+
+# pipdeptree prints out a lot of information because lftools pulls in many
+# dependencies. Let's only print it if we want to debug.
+# echo "----> Pip Dependency Tree"
+# $PYTHON -m pip install --quiet --upgrade pipdeptree
+# $PYTHON -m pipdeptree