X-Git-Url: https://gerrit.linuxfoundation.org/infra/gitweb?a=blobdiff_plain;f=shell%2Fjjb-verify-job.sh;h=509b9533b3da8ae06af71fb16f65c70e70aee4cd;hb=04ddcaa1631de196b5aac96215318d7dee70d0e1;hp=bfa2622a0f9a1f8cb7fc2b577c57b374b778d2e6;hpb=851b0b6d0cfe84e986548fd596a9b2f18413fefd;p=releng%2Fglobal-jjb.git

diff --git a/shell/jjb-verify-job.sh b/shell/jjb-verify-job.sh
index bfa2622a..509b9533 100644
--- a/shell/jjb-verify-job.sh
+++ b/shell/jjb-verify-job.sh
@@ -10,6 +10,9 @@
 ##############################################################################
 echo "---> jjb-verify-job.sh"
 
+# Ensure we fail the job if any steps fail.
+set -eu -o pipefail
+
 jenkins-jobs -l DEBUG test --recursive -o archives/job-configs jjb/
 
 # Sort job output into sub-directories. On large Jenkins systems that have
@@ -18,11 +21,10 @@ jenkins-jobs -l DEBUG test --recursive -o archives/job-configs jjb/
 pushd archives/job-configs
 for letter in {a..z}
 do
-    ls "$letter"* > /dev/null 2>&1
-    if [[ "$?" -eq 0 ]]
+    if [[ $(ls "$letter"* > /dev/null 2>&1) -eq 0 ]]
     then
         mkdir "$letter"
-        find . -type f -maxdepth 1 -name "$letter*" -exec mv {} "$letter" \;
+        find . -maxdepth 1 -type f -name "$letter*" -exec mv {} "$letter" \;
     fi
 done
 popd