X-Git-Url: https://gerrit.linuxfoundation.org/infra/gitweb?a=blobdiff_plain;f=shell%2Fjjb-install.sh;h=baaa5d70f852287a52c909bd73935e66b0227217;hb=11bccd3d96d180f93ae96cd330e23565ba351aa5;hp=63d16947797f7f80902adb0a4e5ae2ca1b801607;hpb=851b0b6d0cfe84e986548fd596a9b2f18413fefd;p=releng%2Fglobal-jjb.git

diff --git a/shell/jjb-install.sh b/shell/jjb-install.sh
index 63d16947..baaa5d70 100644
--- a/shell/jjb-install.sh
+++ b/shell/jjb-install.sh
@@ -1,5 +1,5 @@
-#!/bin/bash
-# @License EPL-1.0 <http://spdx.org/licenses/EPL-1.0>
+#!/bin/bash -l
+# SPDX-License-Identifier: EPL-1.0
 ##############################################################################
 # Copyright (c) 2017 The Linux Foundation and others.
 #
@@ -10,9 +10,19 @@
 ##############################################################################
 echo "---> jjb-install.sh"
 
-virtualenv "$WORKSPACE/.virtualenvs/jjb"
-# shellcheck source=./.virtualenvs/jjb/bin/activate disable=SC1091
-source "$WORKSPACE/.virtualenvs/jjb/bin/activate"
-pip install --upgrade pip
-pip install --upgrade "jenkins-job-builder==$JJB_VERSION"
+# Ensure we fail the job if any steps fail.
+# DO NOT set -u as virtualenv's activate script has unbound variables
+set -e -o pipefail
+
+# Create a virtualenv in a temporary directoy and write it down to used
+# or cleaned up later; cleanup is done in the script jjb-cleanup.sh.
+JJB_VENV="$(mktemp -d)"
+export JJB_VENV
+virtualenv "$JJB_VENV"
+echo "JJB_VENV=$JJB_VENV" > "$WORKSPACE/.jjb.properties"
+# shellcheck source=$VENV_DIR/bin/activate disable=SC1091
+source "$JJB_VENV/bin/activate"
+python -m pip install --quiet --upgrade "jenkins-job-builder==$JJB_VERSION"
+
+echo "----> pip freeze"
 pip freeze