X-Git-Url: https://gerrit.linuxfoundation.org/infra/gitweb?a=blobdiff_plain;f=jenkins-init-scripts%2Flf-env.sh;h=d0ea6251dec366ca6bc41c71efefaacc79edae9f;hb=25b3268055b338bc2ea0d83cb5f7fa0e1199dbb7;hp=5c621041b070592c02c9de7008f7ca15f076b16e;hpb=0ea191599b6edf76fab6bd5f5619e4bb8a73713e;p=releng%2Fglobal-jjb.git diff --git a/jenkins-init-scripts/lf-env.sh b/jenkins-init-scripts/lf-env.sh index 5c621041..d0ea6251 100644 --- a/jenkins-init-scripts/lf-env.sh +++ b/jenkins-init-scripts/lf-env.sh @@ -1,4 +1,5 @@ #!/usr/bin/no-execute +# shellcheck shell=bash # SPDX-License-Identifier: EPL-1.0 ############################################################################## @@ -22,7 +23,8 @@ # ################################################################################ # -# Name: lf-echo-stderr +# NAME +# lf-echo-stderr # # SYNOPSIS # source ~/lf-env.sh @@ -37,12 +39,14 @@ # ################################################################################ -function lf-echo-stderr() { echo "$@" 1>&2; } +lf-echo-stderr () { + echo "$@" 1>&2 +} ################################################################################ # # NAME -# lf-boolean() +# lf-boolean # # SYNOPSIS # # shellcheck disable=SC1090 @@ -64,10 +68,10 @@ function lf-echo-stderr() { echo "$@" 1>&2; } # ################################################################################ -function lf-boolean() -{ +lf-boolean () { if (( $# != 1 )); then - echo "ERROR: ${FUNCNAME[0]}() line: ${BASH_LINENO[0]} : Missing Required Argument" + echo "ERROR: ${FUNCNAME[0]}() line: ${BASH_LINENO[0]} :"\ + " Missing Required Argument" return 1 fi local bool @@ -76,11 +80,13 @@ function lf-boolean() true) return 0 ;; false) return 1 ;; '') - lf-echo-stderr "ERROR: ${FUNCNAME[0]}() line:{BASH_LINENO[0]} : A boolean cannot be a empty string" >&2 - return 2 - ;; + lf-echo-stderr "ERROR: ${FUNCNAME[0]}() line:{BASH_LINENO[0]} :"\ + " A boolean cannot be a empty string" >&2 + return 2 + ;; *) - lf-echo-stderr "ERROR: ${FUNCNAME[0]}() line: ${BASH_LINENO[0]} : Invalid value for a boolean: '$bool'" + lf-echo-stderr "ERROR: ${FUNCNAME[0]}() line: ${BASH_LINENO[0]} :"\ + " Invalid value for a boolean: '$bool'" return 2 ;; esac @@ -140,25 +146,28 @@ function lf-boolean() # ################################################################################ -function lf-activate-venv() -{ +lf-activate-venv () { lf_venv=$(mktemp -d /tmp/venv-XXXX) local python=python3 local options local set_path=true local install_args="" - options=$(getopt -o 'n:p:' -l 'no-path,python:,system-site-packages' -n "${FUNCNAME[0]}" -- "$@" ) + options=$(getopt -o 'n:p:' -l 'no-path,python:,system-site-packages' \ + -n "${FUNCNAME[0]}" -- "$@" ) eval set -- "$options" while true; do case $1 in -n|--no-path) set_path=false ; shift ;; -p|--python) python=$2 ; shift 2 ;; - --system-site-packages) install_args="--system-site-packages" ; shift ;; + --system-site-packages) install_args="--system-site-packages" ; + shift ;; --) shift; break ;; - *) lf-echo-stderr "${FUNCNAME[0]}(): ERROR: Unknown switch '$1'." ; return 1 ;; + *) lf-echo-stderr \ + "${FUNCNAME[0]}(): ERROR: Unknown switch '$1'." ; + return 1 ;; esac done - if ! type $python > /dev/null; then + if ! type "$python" > /dev/null; then lf-echo-stderr "${FUNCNAME[0]}(): ERROR: Unknown Python: $python" return 1 fi @@ -169,33 +178,38 @@ function lf-activate-venv() python2*) local pkg_list="$*" # For Python2, just create venv and install pip - virtualenv -p $python $lf_venv || return 1 - $lf_venv/bin/pip install --upgrade --quiet pip || return 1 + virtualenv -p "$python" "$lf_venv" || return 1 + "$lf_venv/bin/pip" install --upgrade --quiet pip || return 1 if [[ -z $pkg_list ]]; then echo "${FUNCNAME[0]}(): WARNING: No packages to install" return 0 fi echo "${FUNCNAME[0]}(): INFO: Installing: $pkg_list" - $lf_venv/bin/pip install --upgrade --quiet $pkg_list || return 1 + # $pkg_list is expected to be unquoted + # shellcheck disable=SC2086 + "$lf_venv/bin/pip" install --upgrade --quiet $pkg_list || return 1 ;; python3*) local pkg_list="" # Add version specifier for some packages for arg in "$@"; do case $arg in - jenkins-job-builder) pkg_list+="jenkins-job-builder==${JJB_VERSION:-2.8.0} " ;; + jenkins-job-builder) + pkg_list+="jenkins-job-builder==${JJB_VERSION:-2.8.0} " ;; *) pkg_list+="$arg " ;; esac done - $python -m venv $install_args $lf_venv || return 1 - $lf_venv/bin/pip install --upgrade --quiet pip virtualenv || return 1 + $python -m venv "$install_args" "$lf_venv" || return 1 + "$lf_venv/bin/pip" install --upgrade --quiet pip virtualenv || return 1 if [[ -z $pkg_list ]]; then echo "${FUNCNAME[0]}(): WARNING: No packages to install" return 0 fi echo "${FUNCNAME[0]}(): INFO: Installing: $pkg_list" - $lf_venv/bin/pip install --upgrade --quiet --upgrade-strategy eager \ - $pkg_list || return 1 + # $pkg_list is expected to be unquoted + # shellcheck disable=SC2086 + "$lf_venv/bin/pip" install --upgrade --quiet --upgrade-strategy eager \ + $pkg_list || return 1 ;; *) lf-echo-stderr "${FUNCNAME[0]}(): ERROR: No support for: $python" @@ -210,7 +224,7 @@ function lf-activate-venv() echo "${FUNCNAME[0]}(): INFO: Path not set, lf_venv set to: $lf_venv" fi -} # End lf-activate-venv() +} # End lf-activate-venv ################################################################################ # @@ -232,16 +246,19 @@ function lf-activate-venv() # ################################################################################ -function lf-git-validate-jira-urls() -{ +lf-git-validate-jira-urls () { echo "Checking for JIRA URLs in commit message..." # if JIRA_URL is not defined, nothing to do if [[ -v JIRA_URL ]]; then base_url=$(echo "$JIRA_URL" | awk -F'/' '{print $3}') - jira_link=$(git rev-list --format=%B --max-count=1 HEAD | grep -io "http[s]*://$base_url/" || true) + jira_link=$(git rev-list --format=%B --max-count=1 HEAD | \ + grep -io "http[s]*://$base_url/" || true) if [[ -n $jira_link ]]; then - lf-echo-stderr "${FUNCNAME[0]}(): ERROR: JIRA URL found in commit message" - lf-echo-stderr 'Add jira references as: Issue: -, instead of URLs' + lf-echo-stderr \ + "${FUNCNAME[0]}(): ERROR: JIRA URL found in commit message" + lf-echo-stderr \ + 'Add jira references as: Issue: -,'\ + ' instead of URLs' return 1 fi else @@ -253,7 +270,7 @@ function lf-git-validate-jira-urls() ################################################################################ # # NAME -# lf-jjb-check-ascii() +# lf-jjb-check-ascii # # SYNOPSIS # # shellcheck disable=SC1090 @@ -271,18 +288,21 @@ function lf-git-validate-jira-urls() # ################################################################################ -function lf-jjb-check-ascii() -{ +lf-jjb-check-ascii () { if [[ ! -d "jjb" ]]; then lf-echo-stderr "${FUNCNAME[0]}(): ERROR: missing jjb directory" - lf-echo-stderr "This function can only be run from top of global-jjb directory" + lf-echo-stderr \ + "This function can only be run from top of global-jjb directory" return 1 fi if LC_ALL=C grep -I -r '[^[:print:][:space:]]' jjb/; then - lf-echo-stderr "${FUNCNAME[0]}(): ERROR: Found YAML files containing non-printable characters." + lf-echo-stderr \ + "${FUNCNAME[0]}(): ERROR: Found YAML files containing"\ + " non-printable characters." return 1 fi - echo "${FUNCNAME[0]}(): INFO: All JJB YAML files contain only printable ASCII characters" + echo "${FUNCNAME[0]}(): INFO: All JJB YAML files contain only printable"\ + " ASCII characters" return 0 } @@ -294,11 +314,12 @@ function lf-jjb-check-ascii() # Shellcheck knows they are shell variables and will check for # 'used-before-set'. -function lf-set-maven-options() -{ +lf-set-maven-options () { # Disable 'unused-variable' check # shellcheck disable=SC2034 maven_options="--show-version --batch-mode -Djenkins \ - -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn \ - -Dmaven.repo.local=/tmp/r -Dorg.ops4j.pax.url.mvn.localRepository=/tmp/r" + -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.\ + transfer.Slf4jMavenTransferListener=warn \ + -Dmaven.repo.local=/tmp/r \ + -Dorg.ops4j.pax.url.mvn.localRepository=/tmp/r" }