X-Git-Url: https://gerrit.linuxfoundation.org/infra/gitweb?a=blobdiff_plain;f=docs%2Fbest-practices.rst;h=c298fda6331f21fb44babf81c7427d41af57612a;hb=refs%2Fchanges%2F21%2F11321%2F4;hp=fa78db527c673d9e093db16193aadbe2a77fe1bd;hpb=7481ff9faf394dc6c023b2f0d7a635f24fdbb499;p=releng%2Fglobal-jjb.git diff --git a/docs/best-practices.rst b/docs/best-practices.rst index fa78db52..c298fda6 100644 --- a/docs/best-practices.rst +++ b/docs/best-practices.rst @@ -143,6 +143,8 @@ complete running via the logs-clear-credentials.sh script. This script contains 2. Run the build scripts in this case lftools-install.sh and logs-deploy.sh 3. Remove credentials provided by config-file-provider +.. _preserve-variable-refs: + Preserving Objects in Variable References ========================================= @@ -160,18 +162,10 @@ Example: .. code-block:: yaml - - triggers: - - lf-infra-github-pr-trigger: - trigger-phrase: ^remerge$ - status-context: JJB Merge - permit-all: false - github-hooks: true - github-org: '{github-org}' - github_pr_whitelist: '{obj:github_pr_whitelist}' - github_pr_admin_list: '{obj:github_pr_admin_list}' - -In the above example note the use of underscores in `github_pr_admin_list` and -`github_pr_admin_list`. + .. literalinclude:: _static/github-pr-trigger.example + +In the above example note the use of underscores in ``github_pr_whitelist``, +``github_pr_admin_list``, and ``github_included_regions``. Using single quotes around variables ====================================