X-Git-Url: https://gerrit.linuxfoundation.org/infra/gitweb?a=blobdiff_plain;f=docs%2Fbest-practices.rst;h=199422a631f90ca1938156c9c108d7b36c88b35e;hb=2c01d1c4b9b284118e2854494366e76d41e447f8;hp=d2a1866b12c635411f62bf4d64bfd8e014c69665;hpb=5f601f8ecfeed1ee9124972f62eb6af96cb84f5c;p=releng%2Fglobal-jjb.git

diff --git a/docs/best-practices.rst b/docs/best-practices.rst
index d2a1866b..199422a6 100644
--- a/docs/best-practices.rst
+++ b/docs/best-practices.rst
@@ -181,7 +181,7 @@ Preserving Objects in Variable References
 
 JJB has an option to preserve a data structure object when you want to pass
 it to a template.
-https://docs.openstack.org/infra/jenkins-job-builder/definition.html#variable-references
+https://jenkins-job-builder.readthedocs.io/en/latest/definition.html#variable-references
 
 One thing that is not explicitly covered is the format of the variable name
 that you pass the object to. When you use the `{obj:key}` notation to preserve
@@ -195,7 +195,7 @@ Example:
 
    .. literalinclude:: _static/github-pr-trigger.example
 
-In the above example note the use of underscores in ``github_pr_whitelist``,
+In the above example note the use of underscores in ``github_pr_allowlist``,
 ``github_pr_admin_list``, and ``github_included_regions``.
 
 Using single quotes around variables