X-Git-Url: https://gerrit.linuxfoundation.org/infra/gitweb?a=blobdiff_plain;ds=sidebyside;f=shell%2Fdocker-login.sh;h=92da7e0d03f213c7601f5dcda471825659492e82;hb=f3d8d908f8619e56869968469f860341538e2828;hp=210ce3bbcd9c51869787b1efdfad91d796ff95ef;hpb=633d8e37f1796d6a1be9c3e5ad85f0322622fe64;p=releng%2Fglobal-jjb.git

diff --git a/shell/docker-login.sh b/shell/docker-login.sh
index 210ce3bb..92da7e0d 100644
--- a/shell/docker-login.sh
+++ b/shell/docker-login.sh
@@ -35,6 +35,7 @@ set -eu -o pipefail
 
 # Execute the credential lookup and login to the registry
 do_login() {
+    set +x  # Ensure that no other scripts add `set -x` and print passwords
     echo "$1"
     CREDENTIAL=$(xmlstarlet sel -N "x=http://maven.apache.org/SETTINGS/1.0.0" \
         -t -m "/x:settings/x:servers/x:server[starts-with(x:id, '${1}')]" \
@@ -66,7 +67,7 @@ do_login() {
     then
         docker login -u "$USER" -p "$PASS" -e "$2" "$1"
     else
-        docker login -u "$USER" -p "$PASS"
+        docker login -u "$USER" -p "$PASS" "$1"
     fi
 }