Jenkins cannot handle ${} vars in GitHub project

[releng/global-jjb.git] / shell / lftools-install.sh

diff --git a/shell/lftools-install.sh b/shell/lftools-install.sh
index 527a734..8b1c8f1 100644 (file)
--- a/shell/lftools-install.sh
+++ b/shell/lftools-install.sh
@@ -10,9 +10,19 @@
 ##############################################################################
 echo "---> lftools-install.sh"
 
-virtualenv "$WORKSPACE/.virtualenvs/lftools"
+# Ensure we fail the job if any steps fail.
+# DO NOT set -u as virtualenv's activate script has unbound variables
+set -e -o pipefail
+
+virtualenv --quiet "$WORKSPACE/.virtualenvs/lftools"
 # shellcheck source=./.virtualenvs/lftools/bin/activate disable=SC1091
 source "$WORKSPACE/.virtualenvs/lftools/bin/activate"
-pip install --upgrade pip
-pip install --upgrade "lftools<1.0.0"
-pip freeze
+PYTHON="$WORKSPACE/.virtualenvs/lftools/bin/python"
+$PYTHON -m pip install --quiet --upgrade pip
+$PYTHON -m pip install --quiet --upgrade "lftools<1.0.0"
+
+# pipdeptree prints out a lot of information because lftools pulls in many
+# dependencies. Let's only print it if we want to debug.
+# echo "----> Pip Dependency Tree"
+# $PYTHON -m pip install --quiet --upgrade pipdeptree
+# $PYTHON -m pipdeptree