Resolve ShellCheck errors in shell scripts

[releng/global-jjb.git] / shell / git-validate-jira-urls.sh

diff --git a/shell/git-validate-jira-urls.sh b/shell/git-validate-jira-urls.sh
index 1a8f1ca..4a10772 100644 (file)
--- a/shell/git-validate-jira-urls.sh
+++ b/shell/git-validate-jira-urls.sh
@@ -20,9 +20,9 @@ set +u
 
 if [ -n "${JIRA_URL}" ];
 then
-  BASE_URL=$(echo $JIRA_URL | awk -F'/' '{print $3}')
+  BASE_URL=$(echo "$JIRA_URL" | awk -F'/' '{print $3}')
   JIRA_LINK=$(git rev-list --format=%B --max-count=1 HEAD | grep -io "http[s]*://$BASE_URL/" || true)
-  if [[ ! -z "$JIRA_LINK" ]]
+  if [[ -n "$JIRA_LINK" ]]
   then
     echo 'Remove JIRA URLs from commit message'
     echo 'Add jira references as: Issue: <JIRAKEY>-<ISSUE#>, instead of URLs'