Code Review
/
releng
/
global-jjb.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Merge "Add regex for common-packer var and templates"
[releng/global-jjb.git]
/
ensure-documented.sh
diff --git
a/ensure-documented.sh
b/ensure-documented.sh
index
cab15fc
..
823a542
100755
(executable)
--- a/
ensure-documented.sh
+++ b/
ensure-documented.sh
@@
-15,8
+15,7
@@
mapfile -t jjb_files < <(find jjb -name "*.yaml")
undocumented_count=0
for file in "${jjb_files[@]}"; do
undocumented_count=0
for file in "${jjb_files[@]}"; do
- docs_interests=$(grep -e '\- builder:' \
- -e '\- job-group:' \
+ mapfile -t docs_interests < <(grep -e '\- builder:' \
-e '\- job-template:' \
-e '\- parameter:' \
-e '\- property:' \
-e '\- job-template:' \
-e '\- parameter:' \
-e '\- property:' \
@@
-25,17
+24,18
@@
for file in "${jjb_files[@]}"; do
-e '\- trigger:' \
-e '\- wrapper:' \
-A1 "$file" \
-e '\- trigger:' \
-e '\- wrapper:' \
-A1 "$file" \
- | grep 'name: ' | awk -F': ' '{print $2}' | awk -F"'" '{print $2}' | sort | uniq)
+ | grep 'name: ' | awk -F': ' '{print $2}' | sort | uniq \
+ | tr -d "'" | tr -d '"')
for item in "${docs_interests[@]}"; do
if ! grep -q "$item" "docs/${file//.yaml/.rst}"; then
for item in "${docs_interests[@]}"; do
if ! grep -q "$item" "docs/${file//.yaml/.rst}"; then
- echo "$item"
- let "undocumented_count++"
+ echo "$
file:$
item"
+ (( undocumented_count++ ))
fi
done
done
fi
done
done
-if [
$undocumented_count
-gt 0 ]; then
+if [
"$undocumented_count"
-gt 0 ]; then
echo "Number of undocumented items: $undocumented_count"
exit 1
fi
echo "Number of undocumented items: $undocumented_count"
exit 1
fi